Date: Mon, 20 Aug 2012 11:43:16 -0400 From: George Neville-Neil <gnn@freebsd.org> To: Doug Barton <dougb@FreeBSD.org> Cc: freebsd-ports@FreeBSD.org Subject: Re: devel/zookeeper rc.d script Message-ID: <DB65248B-8A75-476D-9770-8F034C420FCE@freebsd.org> In-Reply-To: <501F6C8E.3030008@FreeBSD.org> References: <86hatodavd.wl%gnn@neville-neil.com> <1341340703.6639@da3m0n8t3r.com> <20120704194917.GA15426@misty.eyesbeyond.com> <2244ACD7-892A-4CA7-90B1-FFF41AF6B317@FreeBSD.org> <49BAAAB5-BF68-43B3-8D7C-B4E49DE29ED3@neville-neil.com> <4FFA4454.5070803@FreeBSD.org> <A74185BD-C150-429D-981E-D9B2C83E283E@neville-neil.com> <4FFA5AF0.607@FreeBSD.org> <8DB0856C-A5D6-4C03-9246-743E51BC8B86@freebsd.org> <501F6C8E.3030008@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Aug 6, 2012, at 03:04 , Doug Barton <dougb@FreeBSD.org> wrote: > On 07/09/2012 08:57, George Neville-Neil wrote: >>=20 >> On Jul 9, 2012, at 00:15 , Doug Barton wrote: >>=20 >>> On 07/08/2012 20:01, George Neville-Neil wrote: >>>>=20 >>>> On Jul 8, 2012, at 22:39 , Doug Barton wrote: >>>>=20 >>>>> On 07/08/2012 19:33, George Neville-Neil wrote: >>>>>> A followup. zookeeper is now ported to Freebsd = (/usr/ports/devel/zookeeper) >>>>>=20 >>>>> George, did you see the PR and the followup from me regarding the = port? >>>>>=20 >>>>=20 >>>> I got a mail from jgh@ but only today figured out what the PR was. >>>=20 >>> Are you not getting your gnn@FreeBSD.org mail? >>>=20 >>>> I'll look at the patches from him tomorrow. >>>=20 >>> I copied the text from my message below for your convenience. >>>=20 >>>> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D169693 >>>=20 >>> Furthermore the rc.d script is a mess, and should not have been >>> committed like it was (numerous missing bits, bad format, set_rcvar, >>> hard-coded /usr/local, no REQUIRE, no KEYWORD: shutdown, etc.). = Please >>> read >>> = http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scrip= ts.html >>> and then ask in freebsd-rc@ if you have any additional questions. = Sorry >>> to be so blunt, but I'm really, really tired of repeating the same = stuff >>> over and over again, and this script is really a mess. >>>=20 >>> Also, don't install the script in do-install, see the web page above >>> (and/or the PR) for USE_RC_SUBR. >>>=20 >>> And FYI, there is no need to have the function in that script. You = could >>> use (for example) start_cmd=3D"$command start" just as well. Not to >>> mention that the function you have should be using $1 as the = argument to >>> $command, not $rc_arg. Reasons why left as an exercise for the = reader ... >=20 > George, >=20 > Some of these issues were covered by the PR, but many of them were = not. > If you have any questions about the changes that are needed you should > feel free to ask on freebsd-rc@FreeBSD.org. >=20 I think many or most of these are addressed by updates being made by Steven Kreuzer to both this port and the zookeeper-devel port. Best, George
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DB65248B-8A75-476D-9770-8F034C420FCE>