Date: Thu, 19 Jul 2012 22:19:20 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Konstantin Belousov <kib@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r238614 - in head/sys: kern sys Message-ID: <20120719201920.GF1401@garage.freebsd.pl> In-Reply-To: <201207191022.q6JAMtbw068159@svn.freebsd.org> References: <201207191022.q6JAMtbw068159@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--udcq9yAoWb9A4FsZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 19, 2012 at 10:22:55AM +0000, Konstantin Belousov wrote: > Author: kib > Date: Thu Jul 19 10:22:54 2012 > New Revision: 238614 > URL: http://svn.freebsd.org/changeset/base/238614 >=20 > Log: > Implement F_DUPFD_CLOEXEC command for fcntl(2), specified by SUSv4. > =20 > PR: standards/169962 > Submitted by: Jukka A. Ukkonen <jau iki fi> > MFC after: 1 week [...] > + if ((flags & DUP_CLOEXEC) !=3D 0) > + fdp->fd_ofileflags[new] =3D fdp->fd_ofileflags[old] | UF_EXCLOSE; > + else > + fdp->fd_ofileflags[new] =3D fdp->fd_ofileflags[old] & ~UF_EXCLOSE; > fdp->fd_ofileflags[new] =3D fdp->fd_ofileflags[old] &~ UF_EXCLOSE; It seems that you forgot to remove the line above, which results in always removing the UF_EXCLOSE flag. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl --udcq9yAoWb9A4FsZ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlAIa8cACgkQForvXbEpPzQT+ACff5pFhQ1rCede2YIgNlVFIy+j VTQAoLDRG4Esp9To5eohNFX0bdzNOC1X =RSPm -----END PGP SIGNATURE----- --udcq9yAoWb9A4FsZ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120719201920.GF1401>