From owner-freebsd-bugs@FreeBSD.ORG  Tue Apr 27 13:40:02 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 468BE1065675
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 27 Apr 2010 13:40:02 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 0ADC38FC17
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 27 Apr 2010 13:40:02 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o3RDe1XN058607
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 27 Apr 2010 13:40:01 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o3RDe1jX058606;
	Tue, 27 Apr 2010 13:40:01 GMT (envelope-from gnats)
Resent-Date: Tue, 27 Apr 2010 13:40:01 GMT
Resent-Message-Id: <201004271340.o3RDe1jX058606@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, pluknet <pluknet@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 528FE1065674
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue, 27 Apr 2010 13:34:52 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 4268E8FC0C
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue, 27 Apr 2010 13:34:52 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o3RDYpi6060526
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 27 Apr 2010 13:34:52 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o3RDYpFt060496;
	Tue, 27 Apr 2010 13:34:51 GMT (envelope-from nobody)
Message-Id: <201004271334.o3RDYpFt060496@www.freebsd.org>
Date: Tue, 27 Apr 2010 13:34:51 GMT
From: pluknet <pluknet@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: misc/146088: [patch] netrate/tcpconnect incorrectly uses err()
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Apr 2010 13:40:02 -0000


>Number:         146088
>Category:       misc
>Synopsis:       [patch] netrate/tcpconnect incorrectly uses err()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 27 13:40:01 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     pluknet
>Release:        HEAD r207204
>Organization:
>Environment:
FreeBSD 9.0-CURRENT #10: Mon Apr 26 22:06:30 UTC 2010
>Description:
In netrate/tcpconnect usage() calls err() if no arguments given (with always errno=0).
That produces dirty error message:
tcpconnect: usage: tcpconnect [ip]: Unknown error: 0
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: tools/tools/netrate/tcpconnect/tcpconnect.c
===================================================================
--- tools/tools/netrate/tcpconnect/tcpconnect.c	(revision 207204)
+++ tools/tools/netrate/tcpconnect/tcpconnect.c	(working copy)
@@ -110,7 +110,7 @@
 	u_int64_t counter;
 
 	if (argc != 2)
-		err(-1, "usage: tcpconnect [ip]");
+		errx(-1, "usage: tcpconnect [ip]");
 
 	bzero(&sin, sizeof(sin));
 	sin.sin_family = AF_INET;


>Release-Note:
>Audit-Trail:
>Unformatted: