From owner-freebsd-current@freebsd.org Thu Nov 10 16:05:53 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E11BDC3ABFD; Thu, 10 Nov 2016 16:05:53 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-it0-x234.google.com (mail-it0-x234.google.com [IPv6:2607:f8b0:4001:c0b::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A9705118; Thu, 10 Nov 2016 16:05:53 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-it0-x234.google.com with SMTP id u205so51314213itc.0; Thu, 10 Nov 2016 08:05:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9pkvsjfuN7IcejQ/HGyqe2tTgpsFDPHDdNiWh6I5K2E=; b=f9SNmQ+ZjywFpCJxskg34Kt2h7y0CKvZjFoui3VEDf3cTEHehf1nfIhpUhseauVcbd NELDlh6/+z5DEWNV81YYc6WfSbMJ8fZOp8IlzjNRraZqtnVV/qOXBS9VpP8v/3l6EneX 2nZ1wYsoSJ983Z4IoplA2SzdywPAtWO70nOaVt2GiKo/O72EbfLTt8sCRsYcMO0ZDg3K GorSVFLOQ9XMEdLVZANDMWwM3EjruptZSGaM3IFOUAto3fn9ooWCCoX9nq1J9vSGxosd ERV8Jsg53frIOXi7lE2fWIbkxqH8AutB11jXoHF0ltF/FU4/58Cjj859enbZsRzy4M9n m1yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9pkvsjfuN7IcejQ/HGyqe2tTgpsFDPHDdNiWh6I5K2E=; b=XTjGAMgs5Nd0C4oOkUuOp+/p8W37UVCSFqub7gfkCJuDln/vswek2a34wJk8t9TAUd /6L4OrM9WTkSMlFUgxryujboaxhl0M1LmBkuWfBjRfHgrgqv1cB/1Q1OqvXIPBRKfD+v rfe7fza3whEmVL0cBVgPZ27HIsCVItAhHesp9LYiORxH9m91VRko4CDKY9R25zm4WK9U 0I+N1PvfvRlkdKqB8V97hK6AFJ+PoPR+dBi+HCoRsDOMYd8PzTo5HRR6fUeDImt5zeua 95QVDiooACte5jJoojTSzGpQECqWlMrqyUj220qTMFGHQ2Z1RixmUV32hT8fFoxiPWsf 8nDw== X-Gm-Message-State: ABUngvcTOw+EbgY62MTq9HiS0sX7Zf4tAn3s/04z/QxVm5tPddY7IEsr5yPIki+oBs+Ke4AJmtVjJHuKQTSIug== X-Received: by 10.107.174.157 with SMTP id n29mr2596370ioo.177.1478793952327; Thu, 10 Nov 2016 08:05:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.36.39.134 with HTTP; Thu, 10 Nov 2016 08:05:51 -0800 (PST) In-Reply-To: <6a337a1d-45e7-d7f2-140c-7499c67b6c0a@FreeBSD.org> References: <06929AC5-D350-4236-A813-56C862B58174@perftech.com> <1AA2BB21-0D6D-42F4-9CB2-3CBB00F389C6@perftech.com> <6a337a1d-45e7-d7f2-140c-7499c67b6c0a@FreeBSD.org> From: Adrian Chadd Date: Thu, 10 Nov 2016 08:05:51 -0800 Message-ID: Subject: Re: SM bus ioctls incorrect in FreeBSD 11 To: Andriy Gapon Cc: Lewis Donzis , freebsd-current , "freebsd-arch@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Nov 2016 16:05:54 -0000 +10 on option 2. Hate to say it, but I'd rather this little corner of freebsd be "right" before it gets more heavily used. -a On 10 November 2016 at 03:21, Andriy Gapon wrote: > On 14/10/2016 18:51, Lewis Donzis wrote: >> Our opinion doesn=E2=80=99t count for much, but I like 2 or 4. Option 1= would >> essentially obviate the entire purpose of changing the structure. Optio= n 2 >> basically finishes the job and makes it work properly. Option 3 is, as = you >> say, unappealing. I have no problem with Option 4, obviously we can cha= nge >> our code back to the old way, but assuming there was a good reason for t= his >> change in the first place, Option 2 seems more logical. >> >> But whatever y=E2=80=99all decide is fine with us, we=E2=80=99ll just ch= ange code to match at >> the appropriate time. > > Anyone interested in the issue, could you please take a look at this revi= ew? > https://reviews.freebsd.org/D8430 > > Thank you. > > -- > Andriy Gapon > _______________________________________________ > freebsd-arch@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org"