From owner-freebsd-ports  Mon Nov 16 10:50:03 1998
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id KAA15353
          for freebsd-ports-outgoing; Mon, 16 Nov 1998 10:50:03 -0800 (PST)
          (envelope-from owner-freebsd-ports@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA15285
          for <freebsd-ports@FreeBSD.org>; Mon, 16 Nov 1998 10:49:58 -0800 (PST)
          (envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.8.8/8.8.5) id KAA03503;
	Mon, 16 Nov 1998 10:50:02 -0800 (PST)
Received: from foo.eng.mindspring.net (foo.eng.mindspring.net [207.69.192.103])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA14160
          for <FreeBSD-gnats-submit@freebsd.org>; Mon, 16 Nov 1998 10:44:49 -0800 (PST)
          (envelope-from cnh@foo.eng.mindspring.net)
Received: (from cnh@localhost)
	by foo.eng.mindspring.net (8.9.1/8.8.8) id NAA29470;
	Mon, 16 Nov 1998 13:47:05 -0500 (EST)
	(envelope-from cnh)
Message-Id: <199811161847.NAA29470@foo.eng.mindspring.net>
Date: Mon, 16 Nov 1998 13:47:05 -0500 (EST)
From: cnh@mindspring.net
Reply-To: cnh@mindspring.net
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: ports/8712: fix for SKIP breakage in -STABLE
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         8712
>Category:       ports
>Synopsis:       fix for SKIP breakage in -STABLE
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-ports
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 16 10:50:01 PST 1998
>Last-Modified:
>Originator:     Christopher N. Harrell
>Organization:
Mindspring Enterprises
>Release:        FreeBSD 2.2.7-STABLE i386
>Environment:

	2.2.7-STABLE w/ no modifications

>Description:

	SKIP does not handle large (>mtu) packets properly.

>How-To-Repeat:

	Install SKIP on two hosts, ping -s 1500 one from the other.

>Fix:

	[cnh@bar /usr/ports/security/skip/work/skip/freebsd]% for i in *.orig; do echo ${i%%.orig}; diff $i ${i%%.orig}; done
	skip_es.c
	1769c1769
	<       m->m_flags &= ~ M_EOR;
	---                                                                                                          
	>       m->m_flags &= ~ M_PROTO1;                                                                            
	2233c2233
	<       outbuf->m_flags |= M_EOR | M_PKTHDR;
	---                                                                                                          
	>       outbuf->m_flags |= M_PROTO1 | M_PKTHDR;                                                              
	skip_if.h
	107c107
	< #define       SKIP_DECRYPTED(m)       ((m)->m_flags & M_EOR)
	---                                                                                                          
	> #define       SKIP_DECRYPTED(m)       ((m)->m_flags & M_PROTO1)                                            

	I believe that skip's use of M_EOR was being misinterpreted by something else.

	It *looks* like M_PROTO1 is a protocol specific flag and can be used safely in
	this way, but this could very well break something else;  Use with caution.

	cheers,
	Christopher
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message