From owner-freebsd-current Thu Jan 4 11:18:02 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id LAA25876 for current-outgoing; Thu, 4 Jan 1996 11:18:02 -0800 (PST) Received: from sequent.kiae.su (sequent.kiae.su [144.206.136.6]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id LAA25862 for ; Thu, 4 Jan 1996 11:17:44 -0800 (PST) Received: by sequent.kiae.su id AA12316 (5.65.kiae-2 ); Thu, 4 Jan 1996 22:14:21 +0300 Received: by sequent.KIAE.su (UUMAIL/2.0); Thu, 4 Jan 96 22:14:20 +0300 Received: (from ache@localhost) by ache.dialup.ru (8.7.3/8.7.3) id WAA00759; Thu, 4 Jan 1996 22:10:15 +0300 (MSK) To: davidg@Root.COM, Andras Olah Cc: current@freebsd.org, "Garrett A. Wollman" References: <19542.820777477@curie.cs.utwente.nl> In-Reply-To: <19542.820777477@curie.cs.utwente.nl>; from Andras Olah at Thu, 04 Jan 1996 18:44:37 +0100 Message-Id: Organization: Olahm Ha-Yetzirah Date: Thu, 4 Jan 1996 22:10:14 +0300 (MSK) X-Mailer: Mail/@ [v2.41 FreeBSD] From: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= (aka Andrey A. Chernov, Black Mage) X-Class: Fast Subject: Re: m_copydata panic & tcp_extensions: some results Lines: 27 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-current@freebsd.org Precedence: bulk In message <19542.820777477@curie.cs.utwente.nl> Andras Olah writes: >> olah 95/11/03 14:19:52 >> >> Modified: sys/netinet tcp_timer.c >> Log: >> Setting the TF_ACKNOW flag was redundant in the REXMT timeout because >> tcp_output() checks for the condition snd_nxt == snd_una. >> >> Reviewed by: davidg, wollman, olah >> Suggested by: Richard Stevens >This was not related to T/TCP, just a cosmetic change suggested by >Richard Stevens on comp.protocols.tcp-ip some time ago. >Unfortunately, this change can cause the m_copydata panic if T/TCP >is used (even if the application uses TCP in the traditional sense) >and some segments are lost. For the people interested in the >anatomy of this bug, I'll describe the problem in full details. Can you commit right fix into -current, please? I can turn tcp_extensions ON and test it. -- Andrey A. Chernov : And I rest so composedly, /Now, in my bed, ache@astral.msk.su : That any beholder /Might fancy me dead - http://dt.demos.su/~ache : Might start at beholding me, /Thinking me dead. RELCOM Team,FreeBSD Team : E.A.Poe From "For Annie" 1849