From owner-freebsd-stable  Sat Jul 27 15:14: 4 2002
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 03A8337B401
	for <freebsd-stable@FreeBSD.ORG>; Sat, 27 Jul 2002 15:13:59 -0700 (PDT)
Received: from web9901.mail.yahoo.com (web9901.mail.yahoo.com [216.136.129.36])
	by mx1.FreeBSD.org (Postfix) with SMTP id 732CF43E42
	for <freebsd-stable@FreeBSD.ORG>; Sat, 27 Jul 2002 15:13:58 -0700 (PDT)
	(envelope-from dmobrien_2001@yahoo.com)
Message-ID: <20020727221358.37195.qmail@web9901.mail.yahoo.com>
Received: from [216.29.200.135] by web9901.mail.yahoo.com via HTTP; Sat, 27 Jul 2002 15:13:58 PDT
Date: Sat, 27 Jul 2002 15:13:58 -0700 (PDT)
From: Dan O'Brien <dmobrien_2001@yahoo.com>
Subject: Re: ATA CDROM Problems 4.6 (and 4.6.1) 
To: Jesse Gross <jesse_gross@yahoo.com>, bmah@FreeBSD.ORG
Cc: FreeBSD-Stable Mailing List <freebsd-stable@FreeBSD.ORG>,
	Eric Chet <ejc@bazzle.com>
In-Reply-To: <20020727213533.72239.qmail@web14105.mail.yahoo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: owner-freebsd-stable@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-stable.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-stable>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-stable>
X-Loop: FreeBSD.ORG

This patch is golden! 

I tested it using the former failing scenario:

mount /cdrom
cd /cdrom/ports
cat ports.tgz > /dev/null

Then I hammered it doing:

cd /cdrom
tar cvf /dev/null .

It hangs together, no errors, no panics.

Put this patch up on the 4.6 Errata, please!

Thanks.

--- Jesse Gross <jesse_gross@yahoo.com> wrote:
> 
> --- Dan O'Brien <dmobrien_2001@yahoo.com> wrote:
> > 
> > --- "Bruce A. Mah" <bmah@FreeBSD.ORG> wrote:
> > > If memory serves me right, "Dan O'Brien" wrote:
> > > > I just upgraded from 4.5 (off the CD Release) to 4.6 (off the
> CD
> > > > release) and yadda yadda yadda ATA CDROM fails per the Errata
> > (big
> > > read
> > > > timeout, etc).  

> Actually there is a newer patch that people (including myself) have
> had
> luck with.
> 
> Try the patch below.
> 
> Jesse Gross
> 
> Index: atapi-cd.c
> ===================================================================
> RCS file: /home/iedowse/CVS/src/sys/dev/ata/atapi-cd.c,v
> retrieving revision 1.48.2.16
> diff -u -r1.48.2.16 atapi-cd.c
> --- atapi-cd.c	27 Mar 2002 19:48:37 -0000	1.48.2.16
> +++ atapi-cd.c	26 Jul 2002 14:22:37 -0000
> @@ -266,7 +266,7 @@
>      dev = make_dev(&acd_cdevsw, dkmakeminor(cdp->lun, 0, 0),
>  		   UID_ROOT, GID_OPERATOR, 0644, "acd%d", cdp->lun);
>      dev->si_drv1 = cdp;
> -    dev->si_iosize_max = 252 * DEV_BSIZE;
> +    dev->si_iosize_max = 64 * DEV_BSIZE;
>      dev->si_bsize_phys = 2048; /* XXX SOS */
>      cdp->dev = dev;
>      cdp->device->flags |= ATA_D_MEDIA_CHANGED;


=====
Dan O'Brien, dmobrien_2001@yahoo.com
Cell: 614-783-4859  Work: 614-476-8473
Home: 740-927-2178  Pataskala, OH  USA
'02 Suzuki DL1000 #00082 Grey

__________________________________________________
Do You Yahoo!?
Yahoo! Health - Feel better, live better
http://health.yahoo.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message