From owner-svn-ports-branches@freebsd.org Wed Jun 13 21:33:25 2018 Return-Path: Delivered-To: svn-ports-branches@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 76A971019A22; Wed, 13 Jun 2018 21:33:25 +0000 (UTC) (envelope-from jrm@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1C3727D996; Wed, 13 Jun 2018 21:33:25 +0000 (UTC) (envelope-from jrm@freebsd.org) Received: from phe.ftfl.ca.ftfl.ca (hlfxns017vw-142-68-132-248.dhcp-dynamic.fibreop.ns.bellaliant.net [142.68.132.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: jrm/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id C2E1A8ECC; Wed, 13 Jun 2018 21:33:24 +0000 (UTC) (envelope-from jrm@freebsd.org) From: Joseph Mingrone To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-branches@freebsd.org Subject: Re: svn commit: r472343 - branches/2018Q2/devel/git-review References: <201806132058.w5DKwCRe066134@repo.freebsd.org> <20180613212906.avfyauyozjkue3lz@atuin.in.mat.cc> Date: Wed, 13 Jun 2018 18:33:24 -0300 In-Reply-To: <20180613212906.avfyauyozjkue3lz@atuin.in.mat.cc> (Mathieu Arnold's message of "Wed, 13 Jun 2018 23:29:06 +0200") Message-ID: <86muvye5i3.fsf@phe.ftfl.ca> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: svn-ports-branches@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for all the branches of the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jun 2018 21:33:25 -0000 --=-=-= Content-Type: text/plain Mathieu Arnold writes: > On Wed, Jun 13, 2018 at 08:58:12PM +0000, Joseph Mingrone wrote: >> Author: jrm >> Date: Wed Jun 13 20:58:12 2018 >> New Revision: 472343 >> URL: https://svnweb.freebsd.org/changeset/ports/472343 >> Log: >> MFH: r472342 >> devel/git-review/Makefile: Update to version 1.26.0 >> PR: 226100 >> Submitted by: w.schwarzenfeld@utanet.at >> Reported by: erj >> Approved by: dereckson@gmail.com (maintainer) >> Approved by: portmgr (implicit) > I just went back to read [1], and looking at the patch, and the commit > message, I highly doubt any of the items in the blanket approval list > match. > 1: https://www.freebsd.org/doc/en/articles/committers-guide/ports.html#ports-qa-blanket Did you read https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226100#c0? That sounds like "Build, runtime or packaging fixes, if the quarterly branch version is currently broken." to me. I probably should have noted that in the commit message. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEVbCTpybDiFVxIrrVNqQMg7DW754FAlshjaRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUACgkQNqQMg7DW 757MMQ//YSEitCPNo16P1dsRxmGmpRF5MIt8S31zcxiWMzUImjCqhELa9j7wQmV2 zILfP0j4GfH3JBw8MP/nqSH4CmZiS14FQP1/eLAJIlPXzimM6g44dQRXJMZtkwnv mSx1zSkQHQZOCx4gzhO39clgvD6ZlEroNci4lkT6HmOIO4EuX7JFDGPmc3bLKTyE sqXV2FWJOX1PAJEDywAX8azwJvvl/Nd7NeF1O98cyNWT6OjWb/uuR+V41oc8rnaO Sd247+qIWOZ43TudUyysvRWXmM2PflcF3DGOGz582NZubqqMSpKWdKqmRW+gRxfN xwXl7Zg3anwuu1G55QIbRipPUXrFCBTTXtSxUqeCtkAWi7x5/YLOjdLcA6CSGtAe +G2EVmjOScS4X/gRArP+SoIE1HgSpHMttlRzjJ3+UnkxpVfkH7TyFXR3CDFq0z6V B8fzsqpke0yuFt/ipiU5/zNXsZ117lSwBX+bSYKbYRCihK6dDzPP40rR3Bho5CVY iEdb06YZcde9fe3Sowlw5kM2HcudBQxxL5D8J7bOPszpc1IaErb4UPvXLPMXunkM tlwUbpmoYqHKdOZQdTAKkGUAnsr43uInQgTqUnMoVjfKnk3Asc4NjzkEWNr6bnpn 1ekhWm5Ug6wNJ49CLMLXI5kfRSIOW8elZsnuODtJdiytgQ0fbW8= =Dcl9 -----END PGP SIGNATURE----- --=-=-=--