From owner-svn-src-head@FreeBSD.ORG Sat Feb 16 12:52:41 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 5728113D; Sat, 16 Feb 2013 12:52:41 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id 4997096E; Sat, 16 Feb 2013 12:52:41 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id r1GCqfTV086089; Sat, 16 Feb 2013 12:52:41 GMT (envelope-from dim@svn.freebsd.org) Received: (from dim@localhost) by svn.freebsd.org (8.14.5/8.14.5/Submit) id r1GCqfOi086088; Sat, 16 Feb 2013 12:52:41 GMT (envelope-from dim@svn.freebsd.org) Message-Id: <201302161252.r1GCqfOi086088@svn.freebsd.org> From: Dimitry Andric Date: Sat, 16 Feb 2013 12:52:41 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r246875 - head/contrib/wpa/src/crypto X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Feb 2013 12:52:41 -0000 Author: dim Date: Sat Feb 16 12:52:40 2013 New Revision: 246875 URL: http://svnweb.freebsd.org/changeset/base/246875 Log: Import change 40eebf235370b6fe6353784ccf01ab92eed062a5 from upstream wpa: From: Jouni Malinen Date: Fri, 15 Jul 2011 13:42:06 +0300 Subject: [PATCH] MD5: Fix clearing of temporary stack memory to use correct length sizeof of the structure instead of the pointer was supposed to be used here. Fix this to clear the full structure at the end of MD5Final(). Found by: clang ToT Reviewed by: rpaulo MFC after: 3 days Modified: head/contrib/wpa/src/crypto/md5-internal.c Modified: head/contrib/wpa/src/crypto/md5-internal.c ============================================================================== --- head/contrib/wpa/src/crypto/md5-internal.c Sat Feb 16 12:48:06 2013 (r246874) +++ head/contrib/wpa/src/crypto/md5-internal.c Sat Feb 16 12:52:40 2013 (r246875) @@ -188,7 +188,7 @@ void MD5Final(unsigned char digest[16], MD5Transform(ctx->buf, (u32 *) ctx->in); byteReverse((unsigned char *) ctx->buf, 4); os_memcpy(digest, ctx->buf, 16); - os_memset(ctx, 0, sizeof(ctx)); /* In case it's sensitive */ + os_memset(ctx, 0, sizeof(*ctx)); /* In case it's sensitive */ } /* The four core functions - F1 is optimized somewhat */