From owner-svn-src-all@FreeBSD.ORG Thu Apr 7 19:45:44 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 95AAD106564A; Thu, 7 Apr 2011 19:45:44 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117]) by mx1.freebsd.org (Postfix) with ESMTP id 1AF998FC14; Thu, 7 Apr 2011 19:45:43 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.4/8.14.4) with ESMTP id p37Jjg7v029510; Thu, 7 Apr 2011 23:45:42 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.4/8.14.4/Submit) id p37Jjgsg029509; Thu, 7 Apr 2011 23:45:42 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Thu, 7 Apr 2011 23:45:42 +0400 From: Gleb Smirnoff To: Marko Zec , julian@FreeBSD.org Message-ID: <20110407194542.GZ84445@FreeBSD.org> References: <201104071140.p37BeAlE039248@svn.freebsd.org> <20110407135440.GX84445@FreeBSD.org> <201104071615.49994.zec@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <201104071615.49994.zec@freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r220416 - head/sys/netgraph X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2011 19:45:44 -0000 On Thu, Apr 07, 2011 at 04:15:49PM +0200, Marko Zec wrote: M> On Thursday 07 April 2011 15:54:40 Gleb Smirnoff wrote: M> > On Thu, Apr 07, 2011 at 11:40:10AM +0000, Marko Zec wrote: M> > M> Author: zec M> > M> Date: Thu Apr 7 11:40:10 2011 M> > M> New Revision: 220416 M> > M> URL: http://svn.freebsd.org/changeset/base/220416 M> > M> M> > M> Log: M> > M> Properly unref ng_hub nodes on shutdown, so that we don't leak them. M> > M> M> > M> MFC after: 3 days M> > M> M> > M> Modified: M> > M> head/sys/netgraph/ng_hub.c M> > M> M> > M> Modified: head/sys/netgraph/ng_hub.c M> > M> M> > =========================================================================== M> >=== M> --- head/sys/netgraph/ng_hub.c Thu Apr 7 11:13:50 2011 (r220415) M> M> > +++ head/sys/netgraph/ng_hub.c Thu Apr 7 11:40:10 2011 (r220416) M> @@ M> > -157,6 +157,8 @@ ng_hub_shutdown(node_p node) M> > M> const priv_p priv = NG_NODE_PRIVATE(node); M> > M> M> > M> free(priv, M_NETGRAPH_HUB); M> > M> + NG_NODE_SET_PRIVATE(node, NULL); M> > M> + NG_NODE_UNREF(node); M> > M> return (0); M> > M> } M> > M> > Do we really need NG_NODE_SET_PRIVATE()? M> M> Most probably not, though the majority of .shutdown method implementations in M> sys/netgraph do include a call to NG_NODE_SET_PRIVATE(node, NULL), so I did a M> C/P from one of those for consistency. If there's a consensus that M> NG_NODE_SET_PRIVATE(node, NULL) in shutdown methods serves no useful purpose M> then we should do a sweep across all the existing nodes... My humble opinion is that they should be swept. At least to avoid more c/p in future. Julian? -- Totus tuus, Glebius.