From owner-freebsd-mips@FreeBSD.ORG  Mon Sep  3 00:59:55 2012
Return-Path: <owner-freebsd-mips@FreeBSD.ORG>
Delivered-To: mips@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1E98F106564A
	for <mips@freebsd.org>; Mon,  3 Sep 2012 00:59:55 +0000 (UTC)
	(envelope-from juli@clockworksquid.com)
Received: from mail-we0-f182.google.com (mail-we0-f182.google.com
	[74.125.82.182])
	by mx1.freebsd.org (Postfix) with ESMTP id A3B3D8FC08
	for <mips@freebsd.org>; Mon,  3 Sep 2012 00:59:54 +0000 (UTC)
Received: by weyx56 with SMTP id x56so3369432wey.13
	for <mips@freebsd.org>; Sun, 02 Sep 2012 17:59:48 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=google.com; s=20120113;
	h=mime-version:sender:in-reply-to:references:from:date
	:x-google-sender-auth:message-id:subject:to:cc:content-type
	:x-gm-message-state;
	bh=fQNmTlXtF1R5LZY2J1UpJYZEG4ofImhz0JYb6K4xPdk=;
	b=PtCKC2qkud/Yn02CsJ4t4SoKAS/CLlEjeXMtsGhMkIN019Tl9ZrfnMUncJWln7dV2W
	y0XcXXUA7gcWdKP6wwwOaA490eqUMLXkYUERuv585BCo2eMZCAzBhIFXTuokaOR7ESHH
	9Orl2HOsOKDuiv8l/KFJy32xr9+N+Qlh9JcCninhcmwuEQhtGIZWrPaWPbHFIEL2gSJ4
	HasqukAPxYHw38YbnuZIkp6a3tizzqY/UhYeJyLarJL8kMiH65Gh4cf2N7KRkF1URB7e
	oF6wKlPE53FKNxdMRlxSucKfiTwfml8Hk0mT2OCVa5i4XEkIiwCegQBfHkYW68ACOixo
	lY3w==
Received: by 10.180.78.40 with SMTP id y8mr9618769wiw.7.1346633988290; Sun, 02
	Sep 2012 17:59:48 -0700 (PDT)
MIME-Version: 1.0
Sender: juli@clockworksquid.com
Received: by 10.223.200.198 with HTTP; Sun, 2 Sep 2012 17:59:28 -0700 (PDT)
In-Reply-To: <5043E6AC.8040101@rice.edu>
References: <5043E6AC.8040101@rice.edu>
From: Juli Mallett <jmallett@FreeBSD.org>
Date: Sun, 2 Sep 2012 17:59:28 -0700
X-Google-Sender-Auth: Yf0T56KOBq7DoUwWPO9xbpO91h4
Message-ID: <CACVs6=_FMsD3eHdo+k7mBPfL9AzoSAM2od+UOX1qspH1x+pX+g@mail.gmail.com>
To: Alan Cox <alc@rice.edu>
Content-Type: text/plain; charset=UTF-8
X-Gm-Message-State: ALoCoQnnKYHP2cTF2W479mBlvdq+6ZHBN4MJ5zto1Ug61ox6MyErVtS/Cje80LJtGBYnolzLLsL3
Cc: mips@freebsd.org
Subject: Re: gxemul_disk.c
X-BeenThere: freebsd-mips@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to MIPS <freebsd-mips.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-mips>
List-Post: <mailto:freebsd-mips@freebsd.org>
List-Help: <mailto:freebsd-mips-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Sep 2012 00:59:55 -0000

Indeed, you seem to be quite right.  Feel free to commit the fix.

Thanks,
Juli.

On Sun, Sep 2, 2012 at 4:07 PM, Alan Cox <alc@rice.edu> wrote:
> There appears to be a simple typo in gxemul_disk.c that prevents changes
> from being written back to the emulated disk:
>
> Index: dev/gxemul/disk/gxemul_disk.c
> ===================================================================
> --- dev/gxemul/disk/gxemul_disk.c       (revision 240002)
> +++ dev/gxemul/disk/gxemul_disk.c       (working copy)
> @@ -286,7 +286,7 @@ gxemul_disk_write(unsigned diskid, const void *buf
>         dst = GXEMUL_DISK_DEV_FUNCTION(GXEMUL_DISK_DEV_BLOCK);
>         memcpy((void *)(uintptr_t)dst, buf, GXEMUL_DISK_DEV_BLOCKSIZE);
>
> -       GXEMUL_DISK_DEV_WRITE(GXEMUL_DISK_DEV_START,
> GXEMUL_DISK_DEV_START_READ);
> +       GXEMUL_DISK_DEV_WRITE(GXEMUL_DISK_DEV_START,
> GXEMUL_DISK_DEV_START_WRITE);
>         switch (GXEMUL_DISK_DEV_READ(GXEMUL_DISK_DEV_STATUS)) {
>         case GXEMUL_DISK_DEV_STATUS_FAILURE:
>                 return (EIO);
>
> Or am I missing something?
>
> Regards,
> Alan
>