From nobody Wed Dec 6 21:02:28 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Slqc358XZz52yHm for ; Wed, 6 Dec 2023 21:02:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Slqc30mJbz3SCm for ; Wed, 6 Dec 2023 21:02:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-50bf4f97752so314249e87.1 for ; Wed, 06 Dec 2023 13:02:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1701896561; x=1702501361; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6+tjlI4P6PVjiWXPVroz9V6jxusFAbfC+h3Cjg+DpIQ=; b=cJe9v8gOzJAgETRCZknJXdInaaBDWccoVzOVYSVIuIIsd/qMK5uter8l/HeNo7HiuU uklvHuvXTWD5Mu7xErby9H8rKQc/uWjgxheTd53gwUA1qaJsepbGWjBwwjsTfk0KYOXL bjJ17yXs4vHVbPu7EJihVNVQk1Ph+uqIul7oqhrd/wiISIQoMQL1prejQxuW/KFRtw7k ICQ2NNjdb5rGqgIiXWWTqq0U6xW7oXTnvBYzFilQBpM2zI7px+PcKiJDlNFeVdEhyw+y JQjnE6acHhSkv7k5QfXb+tILCyPpRx+sUsKxMVaWhfVRJLOhttiZnuy/LrYlaHaNM8Qi wFWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701896561; x=1702501361; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6+tjlI4P6PVjiWXPVroz9V6jxusFAbfC+h3Cjg+DpIQ=; b=HZ03ZVJ4JEWd6Slb9E+qIMT3siNBgIyd/P1v4DLnjMNXEIo7XA/jcsezXjPVsyiGlL DpWqZlJSXLbZk8+gVepSoU+KJ9tsEUWBDf4G1rzbkiLWv8JesXbXPq+4O+1enReBgDeK dDL1cQGwtcKR+tDlN4Fy/7Slx59/DREBwVIHb+rolNfl1yURY0HcyQZA5QowddGnFGvl /cn6f8H68sfTk8v3PkI+enkVZWNnCPuD03SJ4gPKmDYYUCa87SfpkloL9jSBZEUHjmAY 8Mc2n3zwqo0wG2E0o2zhhoEKbDr9ULaKG+UzoQ352O+fJRkzO5+/aSv1OykbjKD5DCvo IQfg== X-Gm-Message-State: AOJu0YzSOD45imIv51lQhoVzEQXYoppf18zujxW6lIgOHe7KgW0+lbw2 tMb/d4BIAznfhvbF8eL4zlq0WRigB797nxr4hqhCTg== X-Google-Smtp-Source: AGHT+IHRtV8poiovlfzd3jJj7S6xga05W/Vv6ItdUlwL3lWZGcUjt4kE88mkelP9AzdslMfz/lEkRuiwdNzM+I8z4mo= X-Received: by 2002:a2e:3c16:0:b0:2ca:68:acf7 with SMTP id j22-20020a2e3c16000000b002ca0068acf7mr1148140lja.4.1701896560870; Wed, 06 Dec 2023 13:02:40 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202302251737.31PHb2R8072300@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Wed, 6 Dec 2023 14:02:28 -0700 Message-ID: Subject: Re: git: 773c13c686e4 - main - kldxref: skip .pkgsave files To: John Baldwin Cc: Warner Losh , src-committers , "" , "" Content-Type: multipart/alternative; boundary="000000000000f4a696060bddab28" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4Slqc30mJbz3SCm --000000000000f4a696060bddab28 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Dec 6, 2023, 1:04 PM John Baldwin wrote: > On 2/25/23 9:37 AM, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D773c13c686e4b6ae9dbbc150b342b82= c3f47d73a > > > > commit 773c13c686e4b6ae9dbbc150b342b82c3f47d73a > > Author: Mina Gali=C4=87 > > AuthorDate: 2023-02-25 17:31:58 +0000 > > Commit: Warner Losh > > CommitDate: 2023-02-25 17:35:43 +0000 > > > > kldxref: skip .pkgsave files > > > > This should help people transitioning from traditional setups to > pkgbase > > experience a lot less friction. > > > > We do this by skipping all files containing two dots. > > > > Reviewed by: imp > > Pull Request: https://github.com/freebsd/freebsd-src/pull/661 > > Differential Revision: https://reviews.freebsd.org/D27959 > > This restriction is too broad and omits all of the modern wifi firmware > klds from linker.hints, e.g. > > /boot/kernel/iwlwifi-3160-17.ucode.ko > /boot/kernel/iwlwifi-3168-29.ucode.ko > /boot/kernel/iwlwifi-7260-17.ucode.ko > /boot/kernel/iwlwifi-7265-17.ucode.ko > /boot/kernel/iwlwifi-7265D-29.ucode.ko > /boot/kernel/iwlwifi-8000C-36.ucode.ko > /boot/kernel/iwlwifi-8265-36.ucode.ko > /boot/kernel/iwlwifi-9000-pu-b0-jf-b0-46.ucode.ko > /boot/kernel/iwlwifi-9260-th-b0-jf-b0-46.ucode.ko > /boot/kernel/iwlwifi-Qu-b0-hr-b0-77.ucode.ko > /boot/kernel/iwlwifi-Qu-b0-jf-b0-77.ucode.ko > /boot/kernel/iwlwifi-Qu-c0-hr-b0-77.ucode.ko > /boot/kernel/iwlwifi-Qu-c0-jf-b0-77.ucode.ko > /boot/kernel/iwlwifi-QuZ-a0-hr-b0-77.ucode.ko > /boot/kernel/iwlwifi-QuZ-a0-jf-b0-77.ucode.ko > /boot/kernel/iwlwifi-cc-a0-77.ucode.ko > /boot/kernel/iwlwifi-so-a0-gf-a0-83.ucode.ko > /boot/kernel/iwlwifi-so-a0-gf-a0.pnvm.ko > /boot/kernel/iwlwifi-so-a0-gf4-a0-83.ucode.ko > /boot/kernel/iwlwifi-so-a0-gf4-a0.pnvm.ko > /boot/kernel/iwlwifi-so-a0-hr-b0-81.ucode.ko > /boot/kernel/iwlwifi-so-a0-jf-b0-77.ucode.ko > /boot/kernel/iwlwifi-ty-a0-gf-a0-83.ucode.ko > /boot/kernel/iwlwifi-ty-a0-gf-a0.pnvm.ko > /boot/kernel/rtw8723d_fw.bin.ko > /boot/kernel/rtw8821c_fw.bin.ko > /boot/kernel/rtw8822b_fw.bin.ko > /boot/kernel/rtw8822c_fw.bin.ko > /boot/kernel/rtw8822c_wow_fw.bin.ko > > all match this pattern and are skipped. > > I'm busy rewriting a bunch of kldxref to be a cross tool using libelf, > but I think here you want to probably revert this and just add pkgsave > to the list of "known bad" suffixes. > Sure. Any reason to not just require .ko? Or do we have to index the kernel too? Warner --=20 > John Baldwin > > --000000000000f4a696060bddab28 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Dec 6, 2023, 1:04 PM John Baldwin <jhb@freebsd.org> wrote:
On 2/25/23 9:37 AM, Warner Losh wrote:
> The branch main has been updated by imp:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=3D773c13c686e4b6ae9dbbc150b342b8= 2c3f47d73a
>
> commit 773c13c686e4b6ae9dbbc150b342b82c3f47d73a
> Author:=C2=A0 =C2=A0 =C2=A0Mina Gali=C4=87 <freebsd@igalic.co>= ;
> AuthorDate: 2023-02-25 17:31:58 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> CommitDate: 2023-02-25 17:35:43 +0000
>
>=C2=A0 =C2=A0 =C2=A0 kldxref: skip .pkgsave files
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 This should help people transitioning from traditi= onal setups to pkgbase
>=C2=A0 =C2=A0 =C2=A0 experience a lot less friction.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 We do this by skipping all files containing two do= ts.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Reviewed by: imp
>=C2=A0 =C2=A0 =C2=A0 Pull Request: htt= ps://github.com/freebsd/freebsd-src/pull/661
>=C2=A0 =C2=A0 =C2=A0 Differential Revision: https:/= /reviews.freebsd.org/D27959

This restriction is too broad and omits all of the modern wifi firmware
klds from linker.hints, e.g.

/boot/kernel/iwlwifi-3160-17.ucode.ko
/boot/kernel/iwlwifi-3168-29.ucode.ko
/boot/kernel/iwlwifi-7260-17.ucode.ko
/boot/kernel/iwlwifi-7265-17.ucode.ko
/boot/kernel/iwlwifi-7265D-29.ucode.ko
/boot/kernel/iwlwifi-8000C-36.ucode.ko
/boot/kernel/iwlwifi-8265-36.ucode.ko
/boot/kernel/iwlwifi-9000-pu-b0-jf-b0-46.ucode.ko
/boot/kernel/iwlwifi-9260-th-b0-jf-b0-46.ucode.ko
/boot/kernel/iwlwifi-Qu-b0-hr-b0-77.ucode.ko
/boot/kernel/iwlwifi-Qu-b0-jf-b0-77.ucode.ko
/boot/kernel/iwlwifi-Qu-c0-hr-b0-77.ucode.ko
/boot/kernel/iwlwifi-Qu-c0-jf-b0-77.ucode.ko
/boot/kernel/iwlwifi-QuZ-a0-hr-b0-77.ucode.ko
/boot/kernel/iwlwifi-QuZ-a0-jf-b0-77.ucode.ko
/boot/kernel/iwlwifi-cc-a0-77.ucode.ko
/boot/kernel/iwlwifi-so-a0-gf-a0-83.ucode.ko
/boot/kernel/iwlwifi-so-a0-gf-a0.pnvm.ko
/boot/kernel/iwlwifi-so-a0-gf4-a0-83.ucode.ko
/boot/kernel/iwlwifi-so-a0-gf4-a0.pnvm.ko
/boot/kernel/iwlwifi-so-a0-hr-b0-81.ucode.ko
/boot/kernel/iwlwifi-so-a0-jf-b0-77.ucode.ko
/boot/kernel/iwlwifi-ty-a0-gf-a0-83.ucode.ko
/boot/kernel/iwlwifi-ty-a0-gf-a0.pnvm.ko
/boot/kernel/rtw8723d_fw.bin.ko
/boot/kernel/rtw8821c_fw.bin.ko
/boot/kernel/rtw8822b_fw.bin.ko
/boot/kernel/rtw8822c_fw.bin.ko
/boot/kernel/rtw8822c_wow_fw.bin.ko

all match this pattern and are skipped.

I'm busy rewriting a bunch of kldxref to be a cross tool using libelf,<= br> but I think here you want to probably revert this and just add pkgsave
to the list of "known bad" suffixes.
=

Sure. Any reason to not just = require .ko? Or do we have to index the kernel too?
=
Warner=C2=A0

<= div dir=3D"auto">
--
John Baldwin

--000000000000f4a696060bddab28--