From owner-svn-src-head@freebsd.org Wed May 9 16:02:10 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1175DFC3D18 for ; Wed, 9 May 2018 16:02:10 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x230.google.com (mail-it0-x230.google.com [IPv6:2607:f8b0:4001:c0b::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8D6F787003 for ; Wed, 9 May 2018 16:02:09 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x230.google.com with SMTP id 70-v6so21252784ity.2 for ; Wed, 09 May 2018 09:02:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ddWT+QN1yRtZXW2gbguEB4oCw2rsLUNhbOxLMa3NstM=; b=riCwccItWoLg/sNaKy7yM0ZOcQuh2QXVnPDI5ajAIX4UMses92jxbFfQs/9hGq1xpV WIomaUxWxMFsAo1Poie+OvjUxTUTnX2BMdM+4xXW9klfdVhmvsa4m99nddz8Lqqp5H1a QWbws22Tmi4yj4gjZbnbv5rksL/ustNe+49R/Fu4AJgKdWu+MTjimTZpSI/rTup+Ilq0 jsOpoLe3BNSxSuQYC846arUtPYlURNPF5Zv/8uEMujbUW6SsPhIl7v4wuKX6p4qYJpeJ R0itzzSyaEIDpQpGjKiCJGE6cN2MAhlQgKa21tU1kM87YdVP7PnZYeyVoNQtyHMHjaYi bmtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ddWT+QN1yRtZXW2gbguEB4oCw2rsLUNhbOxLMa3NstM=; b=aDDOY/KDnYo4gZX2HTr8xzX1zyjlq9zE2tAOodpmxdNYNmTq2ugK8Arg+7qBvhSN6A 2179eedHBiOSZvnMayZFq3glvAR6A2yd++aMmMCeVOFy0Xr187PD8uNzjZ4F8XxmRWWv hEPCKJxybBol4q7NfNRUJJzHjvmd3eWyA0xxDc1YWTteAWsNFpQPrrYvNyKxQuWf4SVg d5KggtLQXw8ZDZF4gD80hufgXfGDERRIS57zJHpBo83Wchn6InGtyERFGxmSVab1Ox70 /YLZW/VNgsrKccqYDSG9nEuhQ3E0pSsN1emKpUpzZuxui/ifdgIO3H8C8C/LAtdWo1O+ FaTg== X-Gm-Message-State: ALKqPwdXZL23Ixjjq1x3+BQ4SV9ParRvwUNFbYUmI6YNNOYasxjduxOl aSZ9rDKPsyl2a4sxpbKqgChaGB39icAsTLay/KlQZg== X-Google-Smtp-Source: AB8JxZqUA/sp+KfMMjlOQEcW7dM4eHFSuDvmhPckpKxXFcKsbDX7cugbxxosR9UJcziH4OfUIB3Qi5cvZwx7CLta3xY= X-Received: by 2002:a24:e983:: with SMTP id f125-v6mr10543159ith.36.1525881727735; Wed, 09 May 2018 09:02:07 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:a649:0:0:0:0:0 with HTTP; Wed, 9 May 2018 09:02:06 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <4065288.o9QKfFzp22@ralph.baldwin.cx> References: <201805090207.w49279t8006603@repo.freebsd.org> <4065288.o9QKfFzp22@ralph.baldwin.cx> From: Warner Losh Date: Wed, 9 May 2018 10:02:06 -0600 X-Google-Sender-Auth: zxtqYUfhu0iiTRNerk_A6DrXd1o Message-ID: Subject: Re: svn commit: r333393 - head/sys/contrib/ipfilter/netinet To: John Baldwin Cc: Cy Schubert , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 16:02:10 -0000 On Wed, May 9, 2018 at 8:58 AM, John Baldwin wrote: > On Wednesday, May 09, 2018 02:07:09 AM Cy Schubert wrote: > > Author: cy > > Date: Wed May 9 02:07:09 2018 > > New Revision: 333393 > > URL: https://svnweb.freebsd.org/changeset/base/333393 > > > > Log: > > Document intentional fallthrough. (CID 976535) > > > > MFC after: 1 week > > > > Modified: > > head/sys/contrib/ipfilter/netinet/fil.c > > > > Modified: head/sys/contrib/ipfilter/netinet/fil.c > > ============================================================ > ================== > > --- head/sys/contrib/ipfilter/netinet/fil.c Wed May 9 02:02:58 2018 > (r333392) > > +++ head/sys/contrib/ipfilter/netinet/fil.c Wed May 9 02:07:09 2018 > (r333393) > > @@ -1299,6 +1299,7 @@ ipf_pr_icmp(fin) > > } > > } > > #endif > > + /* fallthrough is intentional */ > > case ICMP_SOURCEQUENCH : > > case ICMP_REDIRECT : > > case ICMP_TIMXCEED : > > Hmm, normal FreeBSD style here is to use /* FALLTHROUGH */, and there are > three other instances of that style in ipfilter already (and none others > using this comment style). > /* FALLTHROUGH */ is actually an old-school lint directive that other tools have picked up. Warner