From owner-svn-src-all@FreeBSD.ORG Wed Sep 15 16:14:47 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 16BDC1065775; Wed, 15 Sep 2010 16:14:47 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id DA52A8FC0C; Wed, 15 Sep 2010 16:14:46 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 6297346C05; Wed, 15 Sep 2010 12:14:46 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 915CE8A04F; Wed, 15 Sep 2010 12:14:45 -0400 (EDT) From: John Baldwin To: Andriy Gapon Date: Wed, 15 Sep 2010 11:57:24 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <201009151002.o8FA2kvO029237@svn.freebsd.org> In-Reply-To: <201009151002.o8FA2kvO029237@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201009151157.24735.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Wed, 15 Sep 2010 12:14:45 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212647 - head/sys/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2010 16:14:47 -0000 On Wednesday, September 15, 2010 6:02:46 am Andriy Gapon wrote: > Author: avg > Date: Wed Sep 15 10:02:46 2010 > New Revision: 212647 > URL: http://svn.freebsd.org/changeset/base/212647 > > Log: > sys/pcpu.h: remove a workaround for a fixed ld bug > > The workaround was incorrectly documented as having something to do with > set_pcpu section's progbits, but in fact it was for incorrect placement > of __start_set_pcpu because of the bug in ld. > The bug was fixed in r210245, see commit message for details. > > A side-effect of the workaround was that a zero-size set_pcpu section was > produced for modules, source code of which included pcpu.h but didn't > actually define any dynamic per-cpu variables. > This commit should remove the side-effect. > > The same workaround is present sys/net/vnet.h, has an analogous side-effect > and can be removed as well. > > An UPDATING entry that warns about a need for recent ld is following. > > MFC after: 1 month > > Modified: > head/sys/sys/pcpu.h > > Modified: head/sys/sys/pcpu.h > ============================================================================== > --- head/sys/sys/pcpu.h Wed Sep 15 09:48:18 2010 (r212646) > +++ head/sys/sys/pcpu.h Wed Sep 15 10:02:46 2010 (r212647) > @@ -44,24 +44,10 @@ > > /* > * Define a set for pcpu data. > - * > - * We don't use SET_DECLARE because it defines the set as 'a' when we > - * want 'aw'. gcc considers uninitialized data in a separate section > - * writable, and there is no generic zero initializer that works for > - * structs and scalars. > */ > extern uintptr_t *__start_set_pcpu; > extern uintptr_t *__stop_set_pcpu; Given that you removed this comment, can you now use SET_DECLARE() here? -- John Baldwin