From nobody Wed Sep 7 09:56:04 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MMyMQ1Hsfz4c4ZY; Wed, 7 Sep 2022 09:56:34 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MMyMQ0pV0z4Lgn; Wed, 7 Sep 2022 09:56:34 +0000 (UTC) (envelope-from tijl@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662544594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ko84Qjg3bP0w6wt4G45OoHTmUnBI9P6gjNHwETWwslA=; b=pFrWewys46g6+ZuQ6Nsd7qWzKudHE8bNqHSmaDRIIVlkEGYVqes703k+peaBYhmwLv+MV+ aSMQUsxx6yUPrYUII2WYWOPWFJhR2a4CjFIGDG/LOGgCT5lp3YQ0Uspy+/3+a5+iQ1satG dGL0rxCYBIABXOHrL5Wsf9bQSGQ3dk8ET2u/ujBWXdzpghk6M2U/OyDpex4VOOkmmvBOD1 u47Tvs2iLVUmoO165Pcohn98UxjU9CgOm5/lfg+i/MHKZUAg8Cz+jc8NFo6qzPsdB9uY6M HcRH0Bi0fPzNCiJX60ndxPlM8Aw1tSTx+0Ye8hmB/XndV+Ekb7Qo9AiDoRCF7w== Received: from localhost (unknown [IPv6:2a02:a03f:894b:4700:bded:a271:6483:7dea]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: tijl) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MMyMP2GT8z13rW; Wed, 7 Sep 2022 09:56:33 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Date: Wed, 7 Sep 2022 11:56:04 +0200 From: =?UTF-8?B?VMSzbA==?= Coosemans To: Konstantin Belousov Cc: Colin Percival , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Subject: Re: git: 5d45f99a1ed8 - stable/13 - i386 doreti: Fix calculation of stack frame size Message-ID: <20220907115604.6e5fbfeb@FreeBSD.org> In-Reply-To: References: <202209021506.282F6Jhx029847@gitrepo.freebsd.org> <01000182feec990a-943b1465-055b-4cb8-984c-225a4feabf7d-000000@email.amazonses.com> <20220906172225.1a4d1064@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662544594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ko84Qjg3bP0w6wt4G45OoHTmUnBI9P6gjNHwETWwslA=; b=gonCetamTp2OM/0Ek4lPqUQf+dCVFf2lnJGIz9Y+QZJyvK9HL5UdYJuqZAnHbvy/xJtRlW NZWg2vKd0Cz0JDyDL8A8PHOdx2zx0D5onm3dH70YSfM8YEyJxAUvb4IKSP9L39KT9lIqI4 bf7inofEZ/gOrouhTiW/qYF2Ljh064x2xKE6CydPMcXcgYko3lK/ONSaH3efhshPj1dRDS Dz04dgWYt+KLd76EzjuQl9hN65758nmZpinnrVJA1S+q/4jjlHbL4sPNxZe50GH0ePrprQ czyWceSI/DiUgtrvjv3hsA40GicsgBJZQLpG139If5xTmurx13vQcWvZ9FQfQQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1662544594; a=rsa-sha256; cv=none; b=kxJZQQqxw2RLHCuhMZBvu0QxCZL4vyVwx2VkLtcJlNmmPLbzoXxOSUVn6ZJBaFk/TosSev nBNI71m8/GN0hopEclLgRO0uZm87OfinbBb2CDWP2arsHMjH0DUsGSYah0jSsU1ztc1SqQ uiE2o49PVqe3QDN7/tpebN43eyVnCYdZU8njOHv2KLjFZk+8kGoD6bGkmNxjtW+FEQ1quY RYAkNMSrN8MmxUcQnvhpmkrfpgamfSYL4rHI131qxJHJDUH1il7zzRK3fVua38j0REMq19 T4qQZBZR9/OLIEVO85a3s8sPA9nN7qAvCmCrPmtbRHjodZPOZwz+osc5WsWRtg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Tue, 6 Sep 2022 20:18:33 +0300 Konstantin Belousov wrote: > On Tue, Sep 06, 2022 at 05:22:25PM +0200, T=C4=B3l Coosemans wrote: >> On Fri, 2 Sep 2022 15:58:14 +0000 Colin Percival >> wrote: =20 >>> On 9/2/22 08:06, Tijl Coosemans wrote: =20 >>>> The branch stable/13 has been updated by tijl: >>>>=20 >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=3D5d45f99a1ed861618d5c4d5= b4252d5eba001ad35 >>>>=20 >>>> commit 5d45f99a1ed861618d5c4d5b4252d5eba001ad35 >>>> Author: Tijl Coosemans >>>> AuthorDate: 2022-09-02 14:16:35 +0000 >>>> Commit: Tijl Coosemans >>>> CommitDate: 2022-09-02 15:02:00 +0000 >>>>=20 >>>> i386 doreti: Fix calculation of stack frame size >>>> =20 >>>> Reviewed by: kib >>>> Fixes: e8b2980e4a12 - i386 doreti: stop saving/restoring= %ecx >>>> =20 >>>> (cherry picked from commit cfdc649e455bc0d37d42c46b59360462e93b43= 00) =20 >>> I assume this MFC took place 23 minutes after the original commit becau= se it >>> was an urgent fix; to avoid the need for assumptions, please indicate t= he >>> reason for an accelerated MFC in the commit message when you skip the n= ormal >>> 3 day waiting period. =20 >>=20 >> Will do. In this case it was a trivial fixup in a critical path. At the >> time I also thought it fixed a panic I was seeing but this turned out to >> be caused by another commit. =20 >=20 > It is not on critical path, at worst it affected vm86 mode only. > That said, 'the other bug' was there before the series. Looking into this again I now believe your change was actually correct. trampstk =3D (uintptr_t)tramp_stack_base + TRAMP_STACK_SZ - VM86_STACK_SPACE So it already has VM86_STACK_SPACE subtracted. Can you double-check this?