From owner-freebsd-stable@FreeBSD.ORG Sun Jul 26 15:12:51 2009 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6DFEA106566B; Sun, 26 Jul 2009 15:12:51 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (skuns.zoral.com.ua [91.193.166.194]) by mx1.freebsd.org (Postfix) with ESMTP id BB7038FC08; Sun, 26 Jul 2009 15:12:50 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id n6QFCjGX053308 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 26 Jul 2009 18:12:46 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id n6QFCjwM070468; Sun, 26 Jul 2009 18:12:45 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id n6QFCjFZ070467; Sun, 26 Jul 2009 18:12:45 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 26 Jul 2009 18:12:45 +0300 From: Kostik Belousov To: Jamie Gritton Message-ID: <20090726151245.GM55190@deviant.kiev.zoral.com.ua> References: <4A6B0BD3.6040206@protected-networks.net> <4A6B9A60.90302@FreeBSD.org> <4A6BAC1A.5080303@protected-networks.net> <20090726120608.GE55190@deviant.kiev.zoral.com.ua> <20090726122230.E245@maildrop.int.zabbadoz.net> <4A6C67F5.8080408@FreeBSD.org> <20090726144227.GK55190@deviant.kiev.zoral.com.ua> <4A6C6D27.2030500@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="w4RKiDPanoqHH247" Content-Disposition: inline In-Reply-To: <4A6C6D27.2030500@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: "Bjoern A. Zeeb" , freebsd-stable Subject: Re: regression with jexec? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jul 2009 15:12:51 -0000 --w4RKiDPanoqHH247 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 26, 2009 at 08:50:15AM -0600, Jamie Gritton wrote: > All true - and I'll add the check you mention to my patch. >=20 > But what about the malloc case? Is it equally valid to say that errno > should not be set when no error occurred? Or are non-syscall libc > functions generally given free reign to overwrite errno in non-error > situations? Yes, they have a blanket to override errno when no error is returned to the caller. Malloc is good example. Errno is defined only after error. --w4RKiDPanoqHH247 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkpscm0ACgkQC3+MBN1Mb4i67ACgiTiYHBtBH22tA2x0KPQ73Kmp pRcAoJnagZVZ+9xzwYoZ4qSnxXFk4SmQ =IfC4 -----END PGP SIGNATURE----- --w4RKiDPanoqHH247--