From owner-svn-ports-all@FreeBSD.ORG Mon Aug 25 13:53:28 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B4198365; Mon, 25 Aug 2014 13:53:28 +0000 (UTC) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E75A03DD9; Mon, 25 Aug 2014 13:53:27 +0000 (UTC) Received: from [192.168.0.22] (unknown [130.255.19.191]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 7ABAF43BF4; Mon, 25 Aug 2014 08:53:09 -0500 (CDT) Message-ID: <53FB3FB3.90508@marino.st> Date: Mon, 25 Aug 2014 15:52:51 +0200 From: John Marino Reply-To: marino@freebsd.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Adam Weinberger , Alexey Dokuchaev Subject: Re: svn commit: r365735 - in head/games: . prboom-plus References: <201408231404.s7NE4Ds7036892@svn.freebsd.org> <20140825093243.GC66191@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Adam Weinberger , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Aug 2014 13:53:28 -0000 On 8/25/2014 15:43, Adam Weinberger wrote: > On 25 Aug, 2014, at 5:32, Alexey Dokuchaev > wrote: >> COMMENT line is wrong. :) > > Because it starts with an article? I’d posit that that article > improves readability of this particular COMMENT. Yes, because it starts with an article. We've been instructed to remove them unconditionally. Hundreds of ports have comments equivalent to "Fork of the doom game engine prboom", so it's not special in any way. Unfortunately portlint doesn't check for this. I'd add this to the current catch-all portlint rule PR. John