From owner-freebsd-rc@FreeBSD.ORG Sun Aug 21 08:14:10 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D10931065675 for ; Sun, 21 Aug 2011 08:14:10 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper-int.allbsd.org [IPv6:2001:2f0:104:e002::2]) by mx1.freebsd.org (Postfix) with ESMTP id 25E758FC14 for ; Sun, 21 Aug 2011 08:14:09 +0000 (UTC) Received: from alph.allbsd.org ([IPv6:2001:2f0:104:e010:862b:2bff:febc:8956]) (authenticated bits=128) by mail.allbsd.org (8.14.4/8.14.4) with ESMTP id p7L8DmSl070386; Sun, 21 Aug 2011 17:13:58 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [IPv6:::1]) (authenticated bits=0) by alph.allbsd.org (8.14.4/8.14.4) with ESMTP id p7L8DirO007175; Sun, 21 Aug 2011 17:13:47 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Sun, 21 Aug 2011 17:13:07 +0900 (JST) Message-Id: <20110821.171307.577871683705351328.hrs@allbsd.org> To: d@delphij.net, delphij@delphij.net From: Hiroki Sato In-Reply-To: <4E50B5E3.90702@delphij.net> References: <4E50B5E3.90702@delphij.net> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Sun_Aug_21_17_13_07_2011_860)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.3 (mail.allbsd.org [IPv6:2001:2f0:104:e001::32]); Sun, 21 Aug 2011 17:13:58 +0900 (JST) X-Spam-Status: No, score=-104.6 required=13.0 tests=BAYES_00, CONTENT_TYPE_PRESENT, RDNS_NONE, SPF_SOFTFAIL, USER_IN_WHITELIST autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on gatekeeper.allbsd.org Cc: freebsd-rc@FreeBSD.org Subject: Re: [PATCH] Don't test if a service is enabled when it's required X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Aug 2011 08:14:10 -0000 ----Security_Multipart(Sun_Aug_21_17_13_07_2011_860)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Xin LI wrote in <4E50B5E3.90702@delphij.net>: de> Hi, de> de> Currently we do a checkyesno before doing forcestatus on a service de> that is required. However, this way if a dependent service is enabled de> but stopped, it would not be started. de> de> For instance: de> de> echo 'mountd_enable="YES"' >> /etc/rc.conf de> /etc/rc.d/mountd stop de> /etc/rc.d/nfsd stop de> /etc/rc.d/nfsd start de> de> Would not start mountd. de> de> I'd like to propose the attached patch since it doesn't seem to be de> necessary that we test the enable status before doing forcestatus. de> de> Comments? Looks reasonable, but if we always use forcestatus just before force_depend(), I think adding the status check into force_depend() is simpler. The "force_depend rpcbind" will do forcestatus first, and then do forcestart if it is not running otherwise no-op, for example. -- Hiroki ----Security_Multipart(Sun_Aug_21_17_13_07_2011_860)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAk5QvhMACgkQTyzT2CeTzy22/gCg2J6IuQPq9nQWj10HPAHddblw 52QAniquOIt17axDLbkLOsPLFkqDlLgm =JBT3 -----END PGP SIGNATURE----- ----Security_Multipart(Sun_Aug_21_17_13_07_2011_860)----