From owner-freebsd-bugs@FreeBSD.ORG  Fri Mar 30 10:26:49 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id A8D81106566C;
	Fri, 30 Mar 2012 10:26:49 +0000 (UTC)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117])
	by mx1.freebsd.org (Postfix) with ESMTP id 2EF828FC0A;
	Fri, 30 Mar 2012 10:26:48 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
	by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id q2UAQeRc053142;
	Fri, 30 Mar 2012 14:26:40 +0400 (MSK)
	(envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
	by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id q2UAQeCf053141;
	Fri, 30 Mar 2012 14:26:40 +0400 (MSK)
	(envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
	glebius@FreeBSD.org using -f
Date: Fri, 30 Mar 2012 14:26:40 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: d@delphij.net
Message-ID: <20120330102640.GX13561@FreeBSD.org>
References: <201203291309.q2TD9leD067354@freefall.freebsd.org>
	<4F74E7A7.2030603@delphij.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <4F74E7A7.2030603@delphij.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-bugs@FreeBSD.org, eadler@FreeBSD.org, bug-followup@FreeBSD.org
Subject: Re: bin/166483: if_nametoindex sends un-initialized bytes to ioctl
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Mar 2012 10:26:49 -0000

On Thu, Mar 29, 2012 at 03:52:23PM -0700, Xin Li wrote:
X> I think we would probably want to put the proposed change under #ifdef
X> PURIFY -- the initialization is not necessary since the uninitialized
X> part is never touched for the whole codepath.

The function isn't performance important, so I think we can put bzero()
here w/o any defines.

More and more people are using valgrind, we'd better have a libc that
valgrind won't whine at, otherwise we would have more noise on mailing
lists.

-- 
Totus tuus, Glebius.