Date: Fri, 30 Mar 2012 14:26:40 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: d@delphij.net Cc: freebsd-bugs@FreeBSD.org, eadler@FreeBSD.org, bug-followup@FreeBSD.org Subject: Re: bin/166483: if_nametoindex sends un-initialized bytes to ioctl Message-ID: <20120330102640.GX13561@FreeBSD.org> In-Reply-To: <4F74E7A7.2030603@delphij.net> References: <201203291309.q2TD9leD067354@freefall.freebsd.org> <4F74E7A7.2030603@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 29, 2012 at 03:52:23PM -0700, Xin Li wrote: X> I think we would probably want to put the proposed change under #ifdef X> PURIFY -- the initialization is not necessary since the uninitialized X> part is never touched for the whole codepath. The function isn't performance important, so I think we can put bzero() here w/o any defines. More and more people are using valgrind, we'd better have a libc that valgrind won't whine at, otherwise we would have more noise on mailing lists. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120330102640.GX13561>