From owner-svn-src-all@FreeBSD.ORG Wed Sep 24 14:12:06 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DE8C1782; Wed, 24 Sep 2014 14:12:06 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B54A7197; Wed, 24 Sep 2014 14:12:06 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-70-85-31.nwrknj.fios.verizon.net [173.70.85.31]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 9EEA5B97F; Wed, 24 Sep 2014 10:12:05 -0400 (EDT) From: John Baldwin To: Bryan Drewery Subject: Re: svn commit: r272032 - head/sys/conf Date: Wed, 24 Sep 2014 09:38:37 -0400 Message-ID: <1598020.ur8YbI6DkF@ralph.baldwin.cx> User-Agent: KMail/4.10.5 (FreeBSD/10.0-STABLE; KDE/4.10.5; amd64; ; ) In-Reply-To: <201409231704.s8NH4Lcv098184@svn.freebsd.org> References: <201409231704.s8NH4Lcv098184@svn.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Wed, 24 Sep 2014 10:12:05 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2014 14:12:07 -0000 On Tuesday, September 23, 2014 05:04:21 PM Bryan Drewery wrote: > Author: bdrewery > Date: Tue Sep 23 17:04:21 2014 > New Revision: 272032 > URL: http://svnweb.freebsd.org/changeset/base/272032 > > Log: > DEBUG_LOCKS no longer modifies 'struct vnode', nor does fstat(1) use it. > fstat(1) now uses libprocstat(9). There is no userland impact to using > this. As your followup noted, it does change the size of 'struct lock' (and thus 'struct vnode') still. While fstat does not use it for live, it probably still uses it for coredumps. However, lsof uses kvm access, so it will break. I don't think that is worth noting here, but more of an FYI. -- John Baldwin