From owner-freebsd-bugs@FreeBSD.ORG  Wed Aug 18 11:10:07 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 92918106564A
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 18 Aug 2010 11:10:07 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 82F9D8FC15
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 18 Aug 2010 11:10:07 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7IBA7QZ059264
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 18 Aug 2010 11:10:07 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7IBA7DG059263;
	Wed, 18 Aug 2010 11:10:07 GMT (envelope-from gnats)
Date: Wed, 18 Aug 2010 11:10:07 GMT
Message-Id: <201008181110.o7IBA7DG059263@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: walter@pelissero.de (Walter C. Pelissero)
Cc: 
Subject: Re: kern/149762: volume labels with rogue characters
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: "Walter C. Pelissero" <walter@pelissero.de>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Aug 2010 11:10:07 -0000

The following reply was made to PR kern/149762; it has been noted by GNATS.

From: walter@pelissero.de (Walter C. Pelissero)
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org
Cc:  
Subject: Re: kern/149762: volume labels with rogue characters
Date: Wed, 18 Aug 2010 13:00:54 +0200

 The patch submitted just before contained a bug.  Please disregard and
 consider the following instead:
 
 *** g_label.c	22 Jun 2010 08:17:20 -0000	1.24.2.4
 --- g_label.c	18 Aug 2010 10:56:09 -0000
 ***************
 *** 136,141 ****
 --- 136,161 ----
   	return (1);
   }
   
 + static int sanitation_level = 1;
 + SYSCTL_INT(_kern_geom_label, OID_AUTO, sanitation, CTLFLAG_RW,
 + 	   &sanitation_level, 0,
 + 	   "Correction applied to labels: 0 = replace '/'s only, 1 = '/' + whitespace and ctrls, 2 = '/' + anything but ASCII printables");
 + 
 + static void
 + sanitise_name (char *name)
 + {
 + 	char *p;
 + 
 + 	for (p = name; *p; ++p) {
 + 		if (*p == '/')
 + 			*p = '#';
 + 		else if (sanitation_level > 0 && *p <= ' ')
 + 			*p = '_';
 + 		else if (sanitation_level > 1 && *p > '~')
 + 			*p = '#';
 + 	}
 + }
 + 
   static struct g_geom *
   g_label_create(struct gctl_req *req, struct g_class *mp, struct g_provider *pp,
       const char *label, const char *dir, off_t mediasize)
 ***************
 *** 156,161 ****
 --- 176,182 ----
   	gp = NULL;
   	cp = NULL;
   	snprintf(name, sizeof(name), "%s/%s", dir, label);
 + 	sanitise_name(name + strlen(dir) + 1);
   	LIST_FOREACH(gp, &mp->geom, geom) {
   		pp2 = LIST_FIRST(&gp->provider);
   		if (pp2 == NULL)
 
 
 -- 
 walter pelissero
 http://www.pelissero.de