Date: Fri, 9 Dec 2011 12:40:06 GMT From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/163076: It is not possible to read in chunks from linprocfs and procfs. Message-ID: <201112091240.pB9Ce6X5093112@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/163076; it has been noted by GNATS. From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Jaakko Heinonen <jh@FreeBSD.org> Cc: Poul-Henning Kamp <phk@phk.freebsd.dk>, Petr Salinger <Petr.Salinger@seznam.cz>, bug-followup@FreeBSD.org, mdf@FreeBSD.org Subject: Re: kern/163076: It is not possible to read in chunks from linprocfs and procfs. Date: Fri, 09 Dec 2011 13:17:59 +0100 Jaakko Heinonen <jh@FreeBSD.org> writes: > After looking at some code using sbufs I think that the sbuf(9) API > change done in r222004 is problematic. I agree, but it's far from the first poorly thought-out change in the sbuf API. The biggest mistake was to allow userland to use the same API and code rather than its own implementation of a subset of the API. > Could we just remove the error check from sbuf_len()? (patch below) I > have Cc'd more people. Why? > sbuf(9) manual page wrongly claims that sbuf_data() will return NULL if > the buffer has overflowed. This used to be the case. I don't know why I removed the check. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201112091240.pB9Ce6X5093112>