From owner-freebsd-threads@FreeBSD.ORG  Thu May 29 09:43:11 2003
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7186737B401
	for <freebsd-threads@freebsd.org>;
	Thu, 29 May 2003 09:43:11 -0700 (PDT)
Received: from h132-197-179-27.gte.com (h132-197-179-27.gte.com
	[132.197.179.27])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 19A7243F93
	for <freebsd-threads@freebsd.org>;
	Thu, 29 May 2003 09:43:10 -0700 (PDT)	(envelope-from ak03@gte.com)
Received: from kanpc.gte.com (ak03@localhost [127.0.0.1])
	h4TGh83D098986;	Thu, 29 May 2003 12:43:08 -0400 (EDT)
	(envelope-from ak03@kanpc.gte.com)
Received: (from ak03@localhost)
	by kanpc.gte.com (8.12.9/8.12.9/Submit) id h4TGh82B098985;
	Thu, 29 May 2003 12:43:08 -0400 (EDT)
Date: Thu, 29 May 2003 12:43:08 -0400
From: Alexander Kabaev <ak03@gte.com>
To: Daniel Eischen <eischen@pcnet1.pcnet.com>
Message-Id: <20030529124308.33ecde45.ak03@gte.com>
In-Reply-To: <Pine.GSO.4.10.10305262356550.22455-100000@pcnet1.pcnet.com>
References: <20030526204634.4c0cfee6.kabaev@mail.ru>
	<Pine.GSO.4.10.10305262356550.22455-100000@pcnet1.pcnet.com>
Organization: Verizon Data Services
X-Mailer: Sylpheed version 0.8.11claws156 (GTK+ 1.2.10;
	i386-portbld-freebsd5.1)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
cc: Alexander Kabaev <kabaev@mail.ru>
cc: freebsd-threads@freebsd.org
Subject: Re: konsole triggers infinite SIGABRT loop in libkse
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 May 2003 16:43:11 -0000

Daniel,

do you have any plans to commit this any time soon?

On Tue, 27 May 2003 00:09:40 -0400 (EDT)
Daniel Eischen <eischen@pcnet1.pcnet.com> wrote:

> 
> Hmm, I think I can see how this could occur after a fork.  Does this
> solve the problem for you:
> 
> Index: thread/thr_sig.c
> ===================================================================
> RCS file: /home/ncvs/src/lib/libpthread/thread/thr_sig.c,v
> retrieving revision 1.51
> diff -u -r1.51 thr_sig.c
> --- thread/thr_sig.c	24 May 2003 02:29:25 -0000	1.51
> +++ thread/thr_sig.c	27 May 2003 04:06:52 -0000
> @@ -175,7 +175,7 @@
>  void
>  _thr_sig_handler(int sig, siginfo_t *info, ucontext_t *ucp)
>  {
> -	void (*sigfunc)(int, siginfo_t *, void *);
> +	__siginfohandler_t *sigfunc;
>  	struct kse *curkse;
>  
>  	curkse = _get_curkse();
> @@ -184,7 +184,8 @@
>  		sigfunc = _thread_sigact[sig - 1].sa_sigaction;
>  		ucp->uc_sigmask = _thr_proc_sigmask;
>  		if (((__sighandler_t *)sigfunc != SIG_DFL) &&
> -		    ((__sighandler_t *)sigfunc != SIG_IGN)) {
> +		    ((__sighandler_t *)sigfunc != SIG_IGN) &&
> +		    (sigfunc != (__siginfohandler_t *)_thr_sig_handler)) {
>  			if (((_thread_sigact[sig - 1].sa_flags & SA_SIGINFO)
>  			    != 0) || (info == NULL))
>  				(*(sigfunc))(sig, info, ucp);
> 

-- 
Alexander Kabaev