From owner-freebsd-current  Fri Jan 28  5:12:31 2000
Delivered-To: freebsd-current@freebsd.org
Received: from fgwmail7.fujitsu.co.jp (fgwmail7.fujitsu.co.jp [192.51.44.37])
	by hub.freebsd.org (Postfix) with ESMTP id 5834E15A25
	for <freebsd-current@FreeBSD.ORG>; Fri, 28 Jan 2000 05:12:28 -0800 (PST)
	(envelope-from shin@nd.net.fujitsu.co.jp)
Received: from m5.gw.fujitsu.co.jp by fgwmail7.fujitsu.co.jp (8.9.3/3.7W-MX9912-Fujitsu Gateway)
	id WAA13001; Fri, 28 Jan 2000 22:12:25 +0900 (JST)
	(envelope-from shin@nd.net.fujitsu.co.jp)
Received: from chisato.nd.net.fujitsu.co.jp by m5.gw.fujitsu.co.jp (8.9.3/3.7W-9912-Fujitsu Domain Master)
	id WAA04393; Fri, 28 Jan 2000 22:12:24 +0900 (JST)
Received: from localhost (dhcp7194.nd.net.fujitsu.co.jp [10.18.7.194]) by chisato.nd.net.fujitsu.co.jp (8.8.5+2.7Wbeta5/3.3W8chisato-970826) with ESMTP id WAA09311; Fri, 28 Jan 2000 22:12:23 +0900 (JST)
To: fritz.heinrichmeyer@fernuni-hagen.de
Cc: freebsd-current@FreeBSD.ORG
Subject: Re: rsh broken?
In-Reply-To: <20000128174826K.shin@nd.net.fujitsu.co.jp>
References: <38915126.789227C@fernuni-hagen.de>
	<20000128174826K.shin@nd.net.fujitsu.co.jp>
X-Mailer: Mew version 1.94 on Emacs 20.4 / Mule 4.0 (HANANOEN)
X-Prom-Mew: Prom-Mew 1.93.4 (procmail reader for Mew)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <20000128221305C.shin@nd.net.fujitsu.co.jp>
Date: Fri, 28 Jan 2000 22:13:05 +0900
From: Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp>
X-Dispatcher: imput version 990905(IM130)
Lines: 35
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

> > When using rsh from a friendly linux-mandrake box i get:
> > 
> > rsh jfh00 ls
> > poll: protocol failure in circuit setup 
> > 
> > from a friendly freebsd box i get:
> > select: protocol failure in circuit setup

Woops bug was in rshd from the beginning. My test had a
leakage. It only happens on AF_INET socket, and I usually use
AF_INET6 socket on my environment so I didon't noticed it.

Please try following patch untill I actually commmit it.

Thanks for reporting it,
Yoshinobu Inoue



Index: rshd.c
===================================================================
RCS file: /home/ncvs/src/libexec/rshd/rshd.c,v
retrieving revision 1.28
diff -u -r1.28 rshd.c
--- rshd.c	2000/01/25 14:52:03	1.28
+++ rshd.c	2000/01/28 12:51:13
@@ -320,7 +320,7 @@
			exit(1);
		}
		fromp->su_port = htons(port);
-		if (connect(s, (struct sockaddr *)fromp, sizeof (*fromp)) < 0) {
+		if (connect(s, (struct sockaddr *)fromp, fromp->su_len) < 0) {
			syslog(LOG_INFO, "connect second port %d: %m", port);
			exit(1);
		}


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message