From owner-freebsd-bugs@FreeBSD.ORG Tue Apr 29 21:00:02 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DFBEB1065686 for ; Tue, 29 Apr 2008 21:00:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B549A8FC24 for ; Tue, 29 Apr 2008 21:00:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m3TL02la042246 for ; Tue, 29 Apr 2008 21:00:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m3TL02kR042245; Tue, 29 Apr 2008 21:00:02 GMT (envelope-from gnats) Resent-Date: Tue, 29 Apr 2008 21:00:02 GMT Resent-Message-Id: <200804292100.m3TL02kR042245@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Lawrence Mayer Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7BEFA1065678 for ; Tue, 29 Apr 2008 20:50:44 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 6B02B8FC0A for ; Tue, 29 Apr 2008 20:50:44 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m3TKo6xI009174 for ; Tue, 29 Apr 2008 20:50:06 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m3TKo68P009173; Tue, 29 Apr 2008 20:50:06 GMT (envelope-from nobody) Message-Id: <200804292050.m3TKo68P009173@www.freebsd.org> Date: Tue, 29 Apr 2008 20:50:06 GMT From: Lawrence Mayer To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/123237: [patch]: sysinstall -- remove dummy quotas option X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Apr 2008 21:00:03 -0000 >Number: 123237 >Category: bin >Synopsis: [patch]: sysinstall -- remove dummy quotas option >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Tue Apr 29 21:00:02 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Lawrence Mayer >Release: n/a >Organization: >Environment: >Description: Attached patch updates sysinstall by removing quotas option from Startup Services Menu. The quotas option sets the variable check_quotas. But changing check_quotas in sysinstall normally has no effect, since 1. enable_quotas=NO by default, which sysinstall can't change and 2. the GENERIC kernel has no support for quotas. The only way check_quotas could ever have any effect would be by compiling a custom kernel with options QUOTA and then setting enable_quotas=YES in rc.conf (neither of which can be done via sysinstall). At that point, check_quotas can also be set in rc.conf. The quotas option in sysinstall is thus a dummy option, which the attached patch removes. >How-To-Repeat: >Fix: Apply attached patch to src/usr.sbin/sysinstall/menus.c Revision 1.431 Patch attached with submission follows: --- menus_1.431.c 2008-04-29 12:49:15.338412800 -0700 +++ menus_1.432.c 2008-04-29 12:56:55.440006400 -0700 @@ -1263,8 +1263,6 @@ { " OSF/1", "This host wants to be able to run DEC OSF/1 binaries.", dmenuVarCheck, configOSF1, NULL, VAR_OSF1_ENABLE "=YES" }, #endif - { " quotas", "This host wishes to check quotas on startup.", - dmenuVarCheck, dmenuToggleVariable, NULL, "check_quotas=YES" }, { NULL } }, }; >Release-Note: >Audit-Trail: >Unformatted: