Date: Tue, 29 Apr 2008 20:50:06 GMT From: Lawrence Mayer <lawmay3@i12.com> To: freebsd-gnats-submit@FreeBSD.org Subject: bin/123237: [patch]: sysinstall -- remove dummy quotas option Message-ID: <200804292050.m3TKo68P009173@www.freebsd.org> Resent-Message-ID: <200804292100.m3TL02kR042245@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 123237 >Category: bin >Synopsis: [patch]: sysinstall -- remove dummy quotas option >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Tue Apr 29 21:00:02 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Lawrence Mayer >Release: n/a >Organization: >Environment: >Description: Attached patch updates sysinstall by removing quotas option from Startup Services Menu. The quotas option sets the variable check_quotas. But changing check_quotas in sysinstall normally has no effect, since 1. enable_quotas=NO by default, which sysinstall can't change and 2. the GENERIC kernel has no support for quotas. The only way check_quotas could ever have any effect would be by compiling a custom kernel with options QUOTA and then setting enable_quotas=YES in rc.conf (neither of which can be done via sysinstall). At that point, check_quotas can also be set in rc.conf. The quotas option in sysinstall is thus a dummy option, which the attached patch removes. >How-To-Repeat: >Fix: Apply attached patch to src/usr.sbin/sysinstall/menus.c Revision 1.431 <http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/src/usr.sbin/sysinstall/menus.c?rev=1.431;content-type=text%2Fplain> Patch attached with submission follows: --- menus_1.431.c 2008-04-29 12:49:15.338412800 -0700 +++ menus_1.432.c 2008-04-29 12:56:55.440006400 -0700 @@ -1263,8 +1263,6 @@ { " OSF/1", "This host wants to be able to run DEC OSF/1 binaries.", dmenuVarCheck, configOSF1, NULL, VAR_OSF1_ENABLE "=YES" }, #endif - { " quotas", "This host wishes to check quotas on startup.", - dmenuVarCheck, dmenuToggleVariable, NULL, "check_quotas=YES" }, { NULL } }, }; >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200804292050.m3TKo68P009173>