From owner-freebsd-hackers@FreeBSD.ORG Fri Dec 24 20:00:16 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 000CC106566B; Fri, 24 Dec 2010 20:00:15 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id E98D58FC12; Fri, 24 Dec 2010 20:00:14 +0000 (UTC) Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id WAA16252; Fri, 24 Dec 2010 22:00:10 +0200 (EET) (envelope-from avg@freebsd.org) Received: from localhost.topspin.kiev.ua ([127.0.0.1]) by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1PWDo9-0007MM-VE; Fri, 24 Dec 2010 22:00:09 +0200 Message-ID: <4D14FBC8.9060304@freebsd.org> Date: Fri, 24 Dec 2010 22:00:08 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.13) Gecko/20101211 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: Artem Belevich References: <20101211215341.0000097c@unknown> <20101213103535.00005f3d@unknown> <4D061E00.7050606@freebsd.org> <4D0F3AD6.9080002@freebsd.org> <4D1077AB.4010707@freebsd.org> In-Reply-To: X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-hackers@freebsd.org, FreeBSD-Current Subject: Re: [dtrace] syscall provider naming convention. X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Dec 2010 20:00:16 -0000 on 24/12/2010 04:02 Artem Belevich said the following: >> I have one comment though. I am not sure about renaming syscall.ko to >> syscall_freebsd.ko. > > You mean systrace_freebsd.ko. Yes, thanks. > I've renamed it for consistency with other systrace provider variants. > I can change it back. I think that I would prefer this. If only for POLA reasons. >> Perhaps we could keep the old name? Or add a new module >> under that name that would load native syscall module and all emulation syscall >> modules (if any)? > > I'm not sure that creating an umbrella 'systrace' module is worth it. > "kldload /boot/kernel/systrace*" should do that just fine. The reason > dtrace exists is that there are number of modules with dtrace > providers that are not easily distinguishable by their name. I agree. I am going on vacation and I don't want to risk, so it looks like I will be able to commit your patch after the holidays. Unless someone else beats me to it. -- Andriy Gapon