From owner-svn-src-all@FreeBSD.ORG Thu Nov 27 08:20:35 2008 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C11DA1065672; Thu, 27 Nov 2008 08:20:35 +0000 (UTC) (envelope-from rdivacky@lev.vlakno.cz) Received: from vlakno.cz (77-93-215-190.static.masterinter.net [77.93.215.190]) by mx1.freebsd.org (Postfix) with ESMTP id 75AC38FC1A; Thu, 27 Nov 2008 08:20:34 +0000 (UTC) (envelope-from rdivacky@lev.vlakno.cz) Received: from localhost (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 8D0479CB181; Thu, 27 Nov 2008 09:16:10 +0100 (CET) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by localhost (lev.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I7Fb+Iq5K5OD; Thu, 27 Nov 2008 09:16:08 +0100 (CET) Received: from lev.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 5BD7E9CB7E8; Thu, 27 Nov 2008 09:16:08 +0100 (CET) Received: (from rdivacky@localhost) by lev.vlakno.cz (8.14.2/8.14.2/Submit) id mAR8G8DF089272; Thu, 27 Nov 2008 09:16:08 +0100 (CET) (envelope-from rdivacky) Date: Thu, 27 Nov 2008 09:16:08 +0100 From: Roman Divacky To: Alexander Kabaev Message-ID: <20081127081607.GA88795@freebsd.org> References: <200811270219.mAR2Ji2M073024@svn.freebsd.org> <20081126213204.14db9a63@kan.dnsalias.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081126213204.14db9a63@kan.dnsalias.net> User-Agent: Mutt/1.4.2.3i Cc: Jack F Vogel , svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r185356 - head/sys/dev/ixgbe X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2008 08:20:35 -0000 On Wed, Nov 26, 2008 at 09:32:04PM -0500, Alexander Kabaev wrote: > On Thu, 27 Nov 2008 02:19:44 +0000 (UTC) > Jack F Vogel wrote: > > > Author: jfv > > Date: Thu Nov 27 02:19:44 2008 > > New Revision: 185356 > > URL: http://svn.freebsd.org/changeset/base/185356 > > > > Log: > > Small nit I just noticed, a pre-decrement should be post. > > > > Modified: > > head/sys/dev/ixgbe/ixgbe.c > > > > Modified: head/sys/dev/ixgbe/ixgbe.c > > ============================================================================== > > --- head/sys/dev/ixgbe/ixgbe.c Thu Nov 27 02:18:43 2008 > > (r185355) +++ head/sys/dev/ixgbe/ixgbe.c Thu Nov 27 02:19:44 > > 2008 (r185356) @@ -3244,7 +3244,7 @@ fail: > > * the rings that completed, the failing case will have > > * cleaned up for itself. 'j' failed, so its the terminus. > > */ > > - for (int i = 0; i < j; ++i) { > > + for (int i = 0; i < j; i++) { > > rxr = &adapter->rx_rings[i]; > > for (int n = 0; n < adapter->num_rx_desc; n++) { > > struct ixgbe_rx_buf *rxbuf; > > Is C99 construct here intentional? If so, when did we agree on using > only C99 compilers on our code base? kernel has been compiling with c99 for a long time now. World is still c89 but compiles cleanly as c99 as of a few days ago (the zfs update + the sendmail fix) I did not test that the world compiles to a correct code using c99 but I am going to work on that soon.