From owner-svn-src-head@FreeBSD.ORG  Sun Sep 23 19:27:11 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id D97331065672;
	Sun, 23 Sep 2012 19:27:11 +0000 (UTC)
	(envelope-from yanegomi@gmail.com)
Received: from mail-oa0-f54.google.com (mail-oa0-f54.google.com
	[209.85.219.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 662458FC08;
	Sun, 23 Sep 2012 19:27:11 +0000 (UTC)
Received: by oagm1 with SMTP id m1so6150618oag.13
	for <multiple recipients>; Sun, 23 Sep 2012 12:27:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=Aw3QYrW2Q8qFKprhoxZHRxRlzLXv1dZWcafzZzp+mBo=;
	b=mOiGj+MAIluH4Nf2b+dt8S3E4IUwcayZRlrfjaLY4EtqZwGClDMI/OPg/xShJ3BLty
	9b7dV5vIKsGdUN5bYlrNrLkGHO29tORSJ170kz2ezOo9K9EWZ755dMNP56MIuxWP9bAw
	qMPxh72z0boE/6pdF0y9mWJwJMBFGxXUjVNNVAQ/mvM3/ofhbCzz0+afQnGxyDm/WJLb
	vWAAHt8wOVj+GnIeYurAtsaRYdxmeOidOoYQN2QGCVw91aA5wJB6hYWFkFjb9QDYTQs6
	l8NKMY1hsk47LbXCPTkx/tNtA2xv+PUeK6kcAxLlk8m05LE3WcKwDPSRk3n8ev13KS36
	gzxQ==
MIME-Version: 1.0
Received: by 10.182.174.100 with SMTP id br4mr8156934obc.62.1348428430617;
	Sun, 23 Sep 2012 12:27:10 -0700 (PDT)
Received: by 10.76.142.201 with HTTP; Sun, 23 Sep 2012 12:27:10 -0700 (PDT)
In-Reply-To: <20120923105220.GL37286@deviant.kiev.zoral.com.ua>
References: <201209230838.q8N8c6Tu056083@svn.freebsd.org>
	<20120923105220.GL37286@deviant.kiev.zoral.com.ua>
Date: Sun, 23 Sep 2012 12:27:10 -0700
Message-ID: <CAGH67wQf5whjgQmXD3Ln_-r=WsLMYrBQUBj_G-HoGf1a5F_4cg@mail.gmail.com>
From: Garrett Cooper <yanegomi@gmail.com>
To: Konstantin Belousov <kostikbel@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head@freebsd.org, Kevin Lo <kevlo@freebsd.org>,
	svn-src-all@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r240850 - head/lib/libstand
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Sep 2012 19:27:12 -0000

On Sun, Sep 23, 2012 at 3:52 AM, Konstantin Belousov
<kostikbel@gmail.com> wrote:
> On Sun, Sep 23, 2012 at 08:38:06AM +0000, Kevin Lo wrote:
>> Author: kevlo
>> Date: Sun Sep 23 08:38:06 2012
>> New Revision: 240850
>> URL: http://svn.freebsd.org/changeset/base/240850
>>
>> Log:
>>   Avoid NULL dereference
>>
>> Modified:
>>   head/lib/libstand/nfs.c

...

> I do not see how this change is useful. libstand' Free() function handles
> NULL parameter fine, as well as all other free(3) implementations I am
> aware of.

    +1. free(3) should silently ignore NULL parameters passed into it.
Thanks,
Garrett