From owner-svn-src-head@freebsd.org Wed Dec 2 04:18:31 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5D4DFA3FA17; Wed, 2 Dec 2015 04:18:31 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: from mail-ig0-x233.google.com (mail-ig0-x233.google.com [IPv6:2607:f8b0:4001:c05::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 244401D0C; Wed, 2 Dec 2015 04:18:31 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: by igvg19 with SMTP id g19so109987859igv.1; Tue, 01 Dec 2015 20:18:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=QEwtHjALwoX8ipFuPUnDmvuj4hIfUg63StBmPoKhfBo=; b=XXfHO029xlfOnllG8glZQGQy8AbRgmV1T+eeLpnIJNqWVcikT5qViBwCK0JPshBOP6 /huX+GiNavAgGxhzikdEiONXFM+3PL26Rx6AWPGZT22u2GdxFpbHyIwAcZOxWmI2fxbC U1/ze+q5ohnwKvCAL2vdUGiFS4BhdAnZSLFIEkwmQ0cS0BLk2n5ZKweP7/vdV0bvMvlr BJ6rD2RmFPSO4CZIO3GGP+etgxSKp7lSdMeGaKzQn1Tx5x2eCHCOzXGJrj4MxsR8Qhzn B7ovHRfBH29uZCr61OesANccgwb82MsjidurhEveux8sOWUfU4tindCykPaDUWQ90WW2 C5bg== MIME-Version: 1.0 X-Received: by 10.50.155.106 with SMTP id vv10mr1647228igb.36.1449029910565; Tue, 01 Dec 2015 20:18:30 -0800 (PST) Sender: crodr001@gmail.com Received: by 10.50.152.69 with HTTP; Tue, 1 Dec 2015 20:18:30 -0800 (PST) In-Reply-To: <201512020211.tB22BcUB082864@repo.freebsd.org> References: <201512020211.tB22BcUB082864@repo.freebsd.org> Date: Tue, 1 Dec 2015 20:18:30 -0800 X-Google-Sender-Auth: D9rG8ZNpvXq69VCeviN_Ljo68ms Message-ID: Subject: Re: svn commit: r291637 - head/cddl/contrib/opensolaris/cmd/plockstat From: Craig Rodrigues To: Bryan Drewery Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2015 04:18:31 -0000 On Tue, Dec 1, 2015 at 6:11 PM, Bryan Drewery wrote: > - (void) snprintf(buf, size, "%#lx", addr); > + (void) snprintf(buf, size, "%#lx", (unsigned long)addr); > return (0); > In the past when I've hit these types of problems, I have found that using %#jx and casting to (uintmax_t) instead seemed to work consistently across different platforms, so you might want to do that here. There are lots of examples in the tree of this pattern. -- Craig