From owner-cvs-src@FreeBSD.ORG Fri Jun 10 21:32:55 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E0DFD16A41C; Fri, 10 Jun 2005 21:32:55 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 94A8E43D49; Fri, 10 Jun 2005 21:32:55 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j5ALWpdF017178; Fri, 10 Jun 2005 14:32:51 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j5ALWpLR017177; Fri, 10 Jun 2005 14:32:51 -0700 Date: Fri, 10 Jun 2005 14:32:51 -0700 From: Brooks Davis To: Julian Elischer Message-ID: <20050610213251.GD11303@odin.ac.hmc.edu> References: <200506101649.j5AGnOPu077043@repoman.freebsd.org> <20050610170818.A32249@grasshopper.cs.duke.edu> <20050610211621.GA11303@odin.ac.hmc.edu> <42AA0619.9000904@elischer.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="n2Pv11Ogg/Ox8ay5" Content-Disposition: inline In-Reply-To: <42AA0619.9000904@elischer.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: Brooks Davis , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andrew Gallatin , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man9 ifnet.9 src/sys/compat/ndis kern_ndis.c subr_ndis.c src/sys/contrib/altq/altq altq_rio.c src/sys/contrib/dev/oltr if_oltr.c if_oltr_pci.c if_oltrvar.h src/sys/contrib/pf/net if_pflog.c if_pflog.h if_pfsync.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2005 21:32:56 -0000 --n2Pv11Ogg/Ox8ay5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 10, 2005 at 02:28:57PM -0700, Julian Elischer wrote: >=20 >=20 > Brooks Davis wrote: >=20 > >On Fri, Jun 10, 2005 at 05:08:18PM -0400, Andrew Gallatin wrote: > >=20 > > > >> > >>What is the appropriate way to detach an interface now? I used to > >>call just ether_ifdetach(ifp); Now I call both if_detach and if_free. > >>Eg: > >> > >> ether_ifdetach(ifp); > >> if_free(ifp); > >> =20 > >> > > > >This is correct. >=20 > why does if_ether_detatch not call if_free()? Symmetry, but importantly, because some drivers change their if_type and this messing up the basic call to if_free. It's possible that in the future we'll want to move this into if_detach. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --n2Pv11Ogg/Ox8ay5 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFCqgcCXY6L6fI4GtQRAu5uAKCt8zQIr+Z4h4XRAg4LoUCko42V1wCeMne7 ANfr/Dgwod+Dxe171RfED9k= =sJxF -----END PGP SIGNATURE----- --n2Pv11Ogg/Ox8ay5--