From owner-freebsd-ports@FreeBSD.ORG Tue Feb 3 12:06:59 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 962E516A4CE for ; Tue, 3 Feb 2004 12:06:59 -0800 (PST) Received: from creme-brulee.marcuscom.com (rrcs-midsouth-24-172-16-118.biz.rr.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id 88C8943D2F for ; Tue, 3 Feb 2004 12:06:57 -0800 (PST) (envelope-from marcus@marcuscom.com) Received: from [10.2.1.4] (vpn-client-4.marcuscom.com [10.2.1.4]) i13K3Gsm088976; Tue, 3 Feb 2004 15:03:16 -0500 (EST) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: Oliver Eikemeier In-Reply-To: <401FF66F.4030907@fillmore-labs.com> References: <1075796985.964405.22320.nullmailer@sinanica.lg2a.datamax> <401F8028.6010609@fillmore-labs.com> <1075827619.780.3.camel@gyros> <401FF66F.4030907@fillmore-labs.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-WhzjXNd29lEfsov7OUC0" Organization: MarcusCom, Inc. Message-Id: <1075838795.780.53.camel@gyros> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Tue, 03 Feb 2004 15:06:35 -0500 X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on creme-brulee.marcuscom.com cc: Vasil Dimov cc: Clement Laforet cc: freebsd-ports@freebsd.org Subject: Re: ports/62302: SIZE in distinfos causes failure with FETCH_CMD=wget X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2004 20:06:59 -0000 --=-WhzjXNd29lEfsov7OUC0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2004-02-03 at 14:28, Oliver Eikemeier wrote: > Joe Marcus Clarke wrote: >=20 > > On Tue, 2004-02-03 at 06:04, Oliver Eikemeier wrote: > >=20 > >>Vasil Dimov wrote: > >> > >>>[...] > >>>Existence of the SIZE line causes `-S bytes' to be passed to the fetch= command > >>>(according to FETCH_CMD). As it appears wget does not support this fea= ture. > >> > >>You run into a similar problem if you have distfiles in /cdrom/ports/di= stfiles > >>and do `make FETCH_CMD=3Dwget FETCH_SYMLINK_DISTFILES=3Dyes fetch'. The= problem gets > >>worse if you do `make FETCH_CMD=3Dcurl fetch'. Either: > >> > >>- only `fetch' is supported, and you can use FETCH_CMD only to specify = a different > >> path to the binary > >> > >>or > >> > >>- we have a reason to support other file transfer utilities (e.g. they = support > >> distributed downloading or special firewall protocols) and have to fi= x this. > >> > >>So, what do you think? > >=20 > > This is fixed in the current bento run as a DISABLE_SIZE macro has been > > added. Defining this in /etc/make.conf will disable the -S argument.=20 > > As well, SIZE attributes are now recorded by default unless NO_SIZE is > > defined. > >=20 > > Joe >=20 > This does not fix FETCH_SYMLINK_DISTFILES nor support curl. Do we support= different > file transfer utilities (wget, curl) or don't we? If we want to, we could= use > something like I never said it added support for anything. However, it allows one to remove the -S argument to FETCH_CMD if desired. As for FETCH_SYMLINK_DISTFILES, this is less-likely to be encountered than SIZE, and can easily be undefined by the user. >=20 > FETCH_EXTRA_ARGS=3D -ARr > FETCH_EXTRA_ARGS+=3D $${CKSIZE:+-S $$CKSIZE} > FETCH_CMD?=3D /usr/bin/fetch ${FETCH_EXTRA_ARGS} >=20 > which is easily extensible to support other tools.=20 Since we already have hooks in bsd.port.mk for alternate FETCH_CMDs, we should probably do something like this. However, I don't think it should be a requirement that we test with different file transfer tools. Joe >=20 > -Oliver --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-WhzjXNd29lEfsov7OUC0 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBAH/9Lb2iPiv4Uz4cRAo1oAKCaOa56UaugXezxnk/UXyZWhCUJBACaA+1Z 0Oj+JawxBWy3wwrG49Jf7Z8= =0iYz -----END PGP SIGNATURE----- --=-WhzjXNd29lEfsov7OUC0--