Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 21 Oct 2017 10:55:28 -0700 (PDT)
From:      "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
To:        "Bjoern A. Zeeb" <bz@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r324810 - in head/sys: amd64/conf arm/conf arm64/conf conf i386/conf mips/conf net powerpc/conf riscv/conf sparc64/conf
Message-ID:  <201710211755.v9LHtSob035303@pdx.rh.CN85.dnsmgr.net>
In-Reply-To: <201710202140.v9KLexFK069227@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> Author: bz
> Date: Fri Oct 20 21:40:59 2017
> New Revision: 324810
> URL: https://svnweb.freebsd.org/changeset/base/324810
> 
> Log:
>   With r181803 on 2008-08-17 23:27:27Z the first VIMAGE commit went into
>   HEAD.  Enable VIMAGE in GENERIC kernels and some others (where GENERIC does
>   not exist) on HEAD.
>   
>   Disable building LINT-VIMAGE with VIMAGE being default.
>   
>   This should give it a lot more exposure in the run-up to 12 to help
>   us evaluate whether to keep it on by default or not.
>   We are also hoping to get better performance testing.
>   The feature can be disabled using nooptions.
>   
>   Requested by:		many
>   Reviewed by:		kristof, emaste, hiren
>   X-MFC after:		never
>   Relnotes:		yes
>   Differential Revision:	https://reviews.freebsd.org/D12639
> 
> Modified:
...
> +options 	VIMAGE			# Subsystem virtualization, e.g. VNET
>  options 	INET			#InterNETworking
>  options 	TCP_HHOOK		# hhook(9) framework for TCP
>  options 	NFSCL			#Network Filesystem Client
> @@ -44,6 +45,11 @@ options 	_KPOSIX_PRIORITY_SCHEDULING #Posix P1003_1B r
>  #options 	INVARIANT_SUPPORT	#Extra sanity checks of internal structures, required by INVARIANTS
>  #options 	WITNESS			#Enable checks to detect deadlocks and cycles
>  #options 	WITNESS_SKIPSPIN	#Don't run witness on spinlocks for speed
> +
> +# The `bpf' device enables the Berkeley Packet Filter.
> +# Be aware of the administrative consequences of enabling this!
> +# Note that 'bpf' is required for DHCP.
> +device		bpf			# Berkeley packet filter

You answer eugen_grosbein question about this being needed to compile,
if that is true, and iirc all the other configs already have bpf on
by default then VIMAGE depends on bpf and at least the comment about
"required for" should be updated until the depenedency on bpf is found
and removed.

That or quickly find and fix the dependency.

-- 
Rod Grimes                                                 rgrimes@freebsd.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201710211755.v9LHtSob035303>