elay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4clJG23pnyz3DNN; Mon, 13 Oct 2025 00:32:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760315546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ur9SWKqZnmWkzHN3h+mBvAvFzOk2d5ZNriGzwZCWkg0=; b=P2Yfh1AU9pKeIvKR6W7Zuk3vOV+Uz2OLIsNBVw9YI0JGVfG6hHhjt+jPjwsAQBVivyXS2y nABKt1ZetAhgLCTFVDKWpfFSHypiW8KHCOeC/u8ad3aI/r4mSQpBMg4CdjkJl0FZpxE4XS rS4XCnbTN1B+TtOC3mPOVFcXUWl34iwCTtwyCd0jQDfRoRh9SGcB0TeNMh/I96KxP3rOxR sqJRgmoCsH4yhBJKsf/gt4iee66Q4p+OCequ+UWvt6M1b1arqvp12u0hno27hiOHk8QX2P 67KrI8TDY2Zzh1WJgP0j1txTg0RtR1uuLEJw84taM5oA7d3C3Q8dsSxSygQhSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760315546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ur9SWKqZnmWkzHN3h+mBvAvFzOk2d5ZNriGzwZCWkg0=; b=ObiwOiAhC3WrNYEsSgz3djimTmHRfFPTXw7mFc3pgVYAjeyuvPkfVoShxEQJyZRXZGcera S7QtGyYfyfLb4UjlAvltsPfH3+/vRIZbcLLu/29cV9x//QTTN4+i9rn7C44ZOZ4wNPYeip RW0Zd6kmrlrkMRQ9VzrPLMZqtUINBfAgJkSH+WZId8hPwFzuXcyODrA7Ppwj8GOo0ydaK+ VnCx/yjoYQRF//+21IM4o8qinS7RZNVWNFnkFy8p2ymQ85QaNnhctClaJgukM+LBl1yM65 UoaPWKaL7RuXqQzAVyl71ocEn5e+t2ouYoT6DXvAhwcpY+8GWLkEOZDtyOvwXA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760315546; a=rsa-sha256; cv=none; b=saHw5P2BRVxSZD/Udl+cjVJM+9u6PMy/oIf5e4JKUTUMjXJ32x37GIdgu0rLwRJQqwBW8O aJ5cRUXkL2h7S744Zkw1Vf6Fu+B2/FDEX8GnB3XdhSB/liF6mm408OsdSuBYpScesMDg39 9L2pbyjproSsgMJC8T9CITXGlOfxOMi/G/z3KYdn3+ow5QE+VoIRZ1j7Oxa6DjZ6ebvpTU IFaS3r2jI+3r6x+49cs7vyqVaLPVi4Ul1aoANXd4XxaJeuQRQ9OicE0semBqKwqOqilkCS h2PO5BkK92N2hCsERUrtnVkqW4Iakh1dzjbzz8zrMwGu0yFDsqJbCQC3BI1RYA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4clJG23DXMzkmN; Mon, 13 Oct 2025 00:32:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59D0WQFE056293; Mon, 13 Oct 2025 00:32:26 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59D0WQTg056290; Mon, 13 Oct 2025 00:32:26 GMT (envelope-from git) Date: Mon, 13 Oct 2025 00:32:26 GMT Message-Id: <202510130032.59D0WQTg056290@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Rick Macklem Subject: git: a7fc4e326c8d - stable/15 - rpc.tlsservd.c: Pin max threads at 1 for now List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: a7fc4e326c8db7b5429b616e0446aac1a041d239 Auto-Submitted: auto-generated The branch stable/15 has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=a7fc4e326c8db7b5429b616e0446aac1a041d239 commit a7fc4e326c8db7b5429b616e0446aac1a041d239 Author: Rick Macklem AuthorDate: 2025-10-10 23:29:25 +0000 Commit: Rick Macklem CommitDate: 2025-10-13 00:29:26 +0000 rpc.tlsservd.c: Pin max threads at 1 for now PR#289734 reports a crash in tcp_use_close() when the rpc.tlsservd daemon is being used. Although I have no, as yet, had time to track down/fix the race, it turns out setting rpctls_maxthreads to 1 avoids the problem. This patch pins rpctls_maxthreads to 1 to avoid the problem, until there is a proper fix. PR: 289734 (cherry picked from commit 7a289fe3cd5c6de7ddbe394b7700b20b0bafdb3e) --- usr.sbin/rpc.tlsservd/rpc.tlsservd.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/usr.sbin/rpc.tlsservd/rpc.tlsservd.c b/usr.sbin/rpc.tlsservd/rpc.tlsservd.c index f07385a2baa7..fb0501b2db4c 100644 --- a/usr.sbin/rpc.tlsservd/rpc.tlsservd.c +++ b/usr.sbin/rpc.tlsservd/rpc.tlsservd.c @@ -168,7 +168,12 @@ main(int argc, char **argv) rpctls_verbose = false; ncpu = (u_int)sysconf(_SC_NPROCESSORS_ONLN); +#ifdef notnow rpctls_maxthreads = ncpu > 1 ? ncpu / 2 : 1; +#else + /* XXX For now, until fixed properly!! */ + rpctls_maxthreads = 1; +#endif while ((ch = getopt_long(argc, argv, "2C:D:dhl:N:n:mp:r:uvWw", longopts, NULL)) != -1) { @@ -199,6 +204,8 @@ main(int argc, char **argv) if (rpctls_maxthreads < 1 || rpctls_maxthreads > ncpu) errx(1, "maximum threads must be between 1 and " "number of CPUs (%d)", ncpu); + /* XXX For now, until fixed properly!! */ + rpctls_maxthreads = 1; break; case 'n': hostname[0] = '@';