From owner-svn-src-all@FreeBSD.ORG Tue Mar 31 10:46:27 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9D1CA316; Tue, 31 Mar 2015 10:46:27 +0000 (UTC) Received: from work.netasq.com (gwlille.netasq.com [91.212.116.1]) by mx1.freebsd.org (Postfix) with ESMTP id 542B8DF9; Tue, 31 Mar 2015 10:46:26 +0000 (UTC) Received: from work.netasq.com (localhost.localdomain [127.0.0.1]) by work.netasq.com (Postfix) with ESMTP id AA954270474B; Tue, 31 Mar 2015 12:46:22 +0200 (CEST) Received: from localhost (localhost.localdomain [127.0.0.1]) by work.netasq.com (Postfix) with ESMTP id 89AAD2704749; Tue, 31 Mar 2015 12:46:22 +0200 (CEST) Received: from work.netasq.com ([127.0.0.1]) by localhost (work.netasq.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KOhET76beb1z; Tue, 31 Mar 2015 12:46:22 +0200 (CEST) Received: from work.netasq.com (localhost.localdomain [127.0.0.1]) by work.netasq.com (Postfix) with ESMTP id 3E8682700468; Tue, 31 Mar 2015 12:46:22 +0200 (CEST) Date: Tue, 31 Mar 2015 12:46:21 +0200 (CEST) From: Emeric POUPON To: Gleb Smirnoff Message-ID: <571890548.26848580.1427798781891.JavaMail.zimbra@stormshield.eu> In-Reply-To: <20150330223836.GY64665@FreeBSD.org> References: <20150329210757.GA64665@FreeBSD.org> <551948A4.1070408@selasky.org> <5519535C.40608@selasky.org> <20150330141616.GC74532@zxy.spb.ru> <1872802434.26738716.1427729028579.JavaMail.zimbra@stormshield.eu> <20150330152707.GP64665@FreeBSD.org> <964618150.26750606.1427732445799.JavaMail.zimbra@stormshield.eu> <20150330223836.GY64665@FreeBSD.org> Subject: Re: svn commit: r280759 - head/sys/netinet MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Thread-Topic: svn commit: r280759 - head/sys/netinet Thread-Index: wMwmtlpWTxjswvglfhgjgUq0AgYb4w== Cc: Hans Petter Selasky , Adrian Chadd , src-committers@freebsd.org, Ian Lepore , svn-src-all@freebsd.org, Slawa Olhovchenkov , svn-src-head@freebsd.org, Fabien Thomas X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2015 10:46:27 -0000 I tested it on a 4 core system: - I still can't see any duplicated id in my tests, so this is good. - as already discussed before, I don't see any performance impact So for me it is good! Emeric ----- Mail original ----- De: "Gleb Smirnoff" =C3=80: "Emeric POUPON" Cc: "Slawa Olhovchenkov" , "Hans Petter Selasky" , "Adrian Chadd" , src-committers@freebsd.org, "= Ian Lepore" , svn-src-all@freebsd.org, svn-src-head@freebs= d.org, "Fabien Thomas" Envoy=C3=A9: Mardi 31 Mars 2015 00:38:36 Objet: Re: svn commit: r280759 - head/sys/netinet On Mon, Mar 30, 2015 at 06:20:45PM +0200, Emeric POUPON wrote: E> Yes, sure! E>=20 E> I will test it tomorrow and tell you the results. E> However, keep in mind I did not see any performance impact with the prev= ious patch. I created a patch that enables RFC6864 and per-CPU ip_id for those packets, that do not qualify for being atomic. It is here: https://reviews.freebsd.org/D2177 --=20 Totus tuus, Glebius.