From owner-freebsd-python@freebsd.org Tue May 4 15:54:31 2021 Return-Path: Delivered-To: freebsd-python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 65B6F6372D9 for ; Tue, 4 May 2021 15:54:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4FZPY32DkLz3hgB for ; Tue, 4 May 2021 15:54:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 4CA6263727E; Tue, 4 May 2021 15:54:31 +0000 (UTC) Delivered-To: python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4C6EE637069 for ; Tue, 4 May 2021 15:54:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FZPY31cwRz3hcn for ; Tue, 4 May 2021 15:54:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 20AA8141DC for ; Tue, 4 May 2021 15:54:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 144FsV87021885 for ; Tue, 4 May 2021 15:54:31 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 144FsVVc021884 for python@FreeBSD.org; Tue, 4 May 2021 15:54:31 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 255579] devel/py-pip: Fails to build with DOCS enabled: SyntaxError: future feature annotations is not defined Date: Tue, 04 May 2021 15:54:31 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jcfyecrayz@liamekaens.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: python@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 May 2021 15:54:31 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255579 --- Comment #2 from John Hein --- (In reply to Kubilay Kocak from comment #1) Yes, I did see that python_requires=3D'>=3D2.7,!=3D3.0.*,!=3D3.1.*,!=3D3.2.*,!=3D3.3.*,!=3D3.4.= *' in setup.py and considered that. My [brief] thinking was: We already deviate from the upstream 'requires' spec due to overriding free= bsd project concerns, namely: we don't support python2.7 or python3.5 anymore. = So that's why the port has USES=3Dpython:3.6+ - if we strictly adhered to a regurgitation of the upstream requirement spec, it should have USES=3Dpython:2.7,3.5+. But, of course, this case is different since it is= not _freebsd_ that chose not to support the older versions, but upstream (altho= ugh possibly unintentionally) when they added the new requirement without updat= ing 'requires'. The freebsd port chooses to optionally build the documentation (if DOCS is = on). Upstream may consider 'build_sphinx' a second class citizen when considering its 'requires'. If so, then it seems it would be okay to set USES=3Dpython= :3.7+. If not, then I agree it is just an outright upstream bug. I suspect you're right, and they DON'T consider build_sphinx a second class citizen, so the full-on 'bug' moniker would be correct. That said, until they fix upstream, our ports tree is [slightly] broken (especially since DOCS is on by default). So that's the main reason I advocated setting USES=3Dpython:3.7+ for now - that can be a reasonable tem= porary workaround (at least when we build with DOCS). The breakage is pretty minor, however, since the default python version is = now > 3.6. Because of that, very few people will hit this bug. If you don't t= hink it's worth our time to commit anything to address the breakage, that's okay with me. I can just close this with a "won't fix" resolution. For now, I'= ll just let this sit and wait a while to hear from upstream. For reference, here is the upstream issue report (yes, that was from me): https://github.com/pypa/pip/issues/9941 No bites yet. --=20 You are receiving this mail because: You are the assignee for the bug.=