From owner-cvs-all  Thu Mar  7  3:48:57 2002
Delivered-To: cvs-all@freebsd.org
Received: from alcatraz.iptelecom.net.ua (alcatraz.iptelecom.net.ua [212.9.224.15])
	by hub.freebsd.org (Postfix) with ESMTP
	id C452737B405; Thu,  7 Mar 2002 03:48:38 -0800 (PST)
Received: from ipcard.iptcom.net (ipcard.iptcom.net [212.9.224.5])
	by alcatraz.iptelecom.net.ua (8.9.3/8.9.3) with ESMTP id NAA80497;
	Thu, 7 Mar 2002 13:48:19 +0200 (EET)
	(envelope-from sobomax@FreeBSD.org)
Received: from vega.vega.com (h211.229.dialup.iptcom.net [212.9.229.211])
	by ipcard.iptcom.net (8.9.3/8.9.3) with ESMTP id NAA35083;
	Thu, 7 Mar 2002 13:47:48 +0200 (EET)
	(envelope-from sobomax@FreeBSD.org)
Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1])
	by vega.vega.com (8.11.6/8.11.3) with ESMTP id g27BkqB11262;
	Thu, 7 Mar 2002 13:46:52 +0200 (EET)
	(envelope-from sobomax@FreeBSD.org)
Message-ID: <3C87535E.142B01AF@FreeBSD.org>
Date: Thu, 07 Mar 2002 13:47:42 +0200
From: Maxim Sobolev <sobomax@FreeBSD.org>
Organization: Vega International Capital
X-Mailer: Mozilla 4.79 [en] (Windows NT 5.0; U)
X-Accept-Language: en,uk,ru
MIME-Version: 1.0
To: Mark Murray <mark@grondar.za>
Cc: obrien@FreeBSD.org, Mark Murray <markm@FreeBSD.org>,
	cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.bin/rwall rwall.c
References: <20020307030244.B63484@dragon.nuxi.com> <200203071127.g27BR2RV009394@grimreaper.grondar.org>
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Mark Murray wrote:
> 
> > -       if ((fd = mkstemp(tmpname)) == -1 || !(fp = fdopen(fd, "r+")))
> > +       fd = mkstemp(tmpname);
> > +       fp = fdopen(fd, "r+");
> > +       if (fd == -1 || !fp)
> >
> > Why did you need to do such code restructuring?
> 
> "Assignment statement in conditional". I also happens to be more readable.

You missed the point - fd should be checked (!=0) before it is
supplied to fdopen(), not after. Otherwise fdopen() might blow out.

-Maxim

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message