From owner-svn-src-all@freebsd.org Tue Feb 21 00:48:20 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9DD70CE6DF4 for ; Tue, 21 Feb 2017 00:48:20 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm2-vm1.bullet.mail.ne1.yahoo.com (nm2-vm1.bullet.mail.ne1.yahoo.com [98.138.91.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 69EFF13BE for ; Tue, 21 Feb 2017 00:48:20 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1487637707; bh=gk9zerFdF/3UwHKpIUpSajjr63FrHy8ogjmudDxFg8I=; h=Subject:To:References:From:Date:In-Reply-To:From:Subject; b=aYwC1guTRBdsap4O5ftnQbPRTMFKdXfGfO1QJA+JlZb89WlnKV4LAxLs+fNZOGnjgHS667X0YkhdQbu92dvbno2quHUqfx8Nc7YexVjHRTBKi7DpUFyB72jlJlPlU8SZRAkeMtD/am6uZSnL0X8NaxbNYCw0QjJADXvHlYKX6gy0bZnEVFPnYuoXmjGTJhEvs7DGlJ0UddNhhxblJLGkvVGb99+Yj09fVzTA8FyKVvHc8MusVH6AhtG83R3uGnv7ozjN6zI1bhTdFJUaNofjZb+RAfekOE/5QzxoPagcSnGuxRnfg4+TsT8RD66cEya15hHnEtTwhG/AVnlVkTZpjw== Received: from [98.138.100.103] by nm2.bullet.mail.ne1.yahoo.com with NNFMP; 21 Feb 2017 00:41:47 -0000 Received: from [98.138.84.46] by tm102.bullet.mail.ne1.yahoo.com with NNFMP; 21 Feb 2017 00:39:47 -0000 Received: from [127.0.0.1] by smtp114.mail.ne1.yahoo.com with NNFMP; 21 Feb 2017 00:39:47 -0000 X-Yahoo-Newman-Id: 760109.17557.bm@smtp114.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: FMaEOocVM1mFpNZMPbn7dilriS6B_M0lnOw45sG4b5vt6k9 ThzJEIIftancrpH6yMIZjPzvK.QszTxgY620bObMrm2qD_xf4zhd3FxKP7zQ OZKTAKAEhHzab7NMbhXtdBuyK0pXcCNln4YHscHnhAlFLhpWTiDtUQBivGIv AmLPmk8HzrHoUTvMvGsKSFCTCNH_MFvWY_RiWeqekfwLmSlVtCyE0bqq7vzP _pVtTBd._XQ24lcyNe2Tba2Ypo.FkHNHjA4bJoqLrHZ21pLDnjBc5sqLrdcA MbMKjMyvLfUvRHinV_C_9v8I3kTsAfYi2Ozl2H9iFXYOoDeLj7GWpPtmIGyi Vqbah47xo60JQj8lCibcowAiL_7_eyVnNfK8F0cdapQDwg2NYH7esG.ZqeM3 Zi2q.xbu2BKdwk3S0HC1_ND3A5eQNHJ7tM_J40FLnaFyndSzYWzkrDbQFDZp SyvB4rhtue8iRPipcPgoxJ0zWjtLFAvUJbQ0urm2wP8cR3267.pkmGW3pk1L ShGbq4LZZvS6fVMVyaU_Adhgru9WD0V7D0z.EToC1GAck X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r313878 - head/sys/kern To: Bryan Drewery , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201702171540.v1HFeOAs074991@repo.freebsd.org> From: Pedro Giffuni Message-ID: <7da9caa5-d938-d2d0-1228-0e8897dc5632@FreeBSD.org> Date: Mon, 20 Feb 2017 19:42:28 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Feb 2017 00:48:20 -0000 FWIW, On 2/20/2017 7:24 PM, Bryan Drewery wrote: > On 2/17/2017 7:40 AM, Mateusz Guzik wrote: >> Author: mjg >> Date: Fri Feb 17 15:40:24 2017 >> New Revision: 313878 >> URL: https://svnweb.freebsd.org/changeset/base/313878 >> >> Log: >> mtx: get rid of file/line args from slow paths if they are unused >> >> This denotes changes which went in by accident in r313877. > I really wish people would just revert their changes and recommit them > properly. The 'svn blame' on the code in r313877 will never show the > commit message here (r313878). So a person would only find this > explanation if they read 'svn log' on the file, which in the case of > sys/kern/kern_mutex.c there are 273 commits for. Are we expected to > read 'svn log' (in the future) for all changes in the hopes that a later > commit happens to mention it? > > As someone who so often is 'svn blame'ing code to understand it better > and to track regressions, commits like this that explain other commits > might as well have never been done. As I mentioned in another thread, other svn configurations (ASF, for example) permit editing the log message: http://help.collab.net/index.jsp?topic=/faq/changelog.html Cheers, Pedro.