From owner-freebsd-bugs@FreeBSD.ORG Wed Mar 20 22:40:00 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id D9759D99 for ; Wed, 20 Mar 2013 22:40:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id BC25690E for ; Wed, 20 Mar 2013 22:40:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r2KMe0Hn005573 for ; Wed, 20 Mar 2013 22:40:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r2KMe01K005572; Wed, 20 Mar 2013 22:40:00 GMT (envelope-from gnats) Resent-Date: Wed, 20 Mar 2013 22:40:00 GMT Resent-Message-Id: <201303202240.r2KMe01K005572@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, hiren panchasara Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id F2E5FB9E for ; Wed, 20 Mar 2013 22:30:22 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id CB0A18BD for ; Wed, 20 Mar 2013 22:30:22 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r2KMUMwV002494 for ; Wed, 20 Mar 2013 22:30:22 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id r2KMUM9u002492; Wed, 20 Mar 2013 22:30:22 GMT (envelope-from nobody) Message-Id: <201303202230.r2KMUM9u002492@red.freebsd.org> Date: Wed, 20 Mar 2013 22:30:22 GMT From: hiren panchasara To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: kern/177164: [patch] Fixing clang warnings at /sys/dev/ips X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Mar 2013 22:40:01 -0000 >Number: 177164 >Category: kern >Synopsis: [patch] Fixing clang warnings at /sys/dev/ips >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Mar 20 22:40:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: hiren panchasara >Release: current >Organization: >Environment: 10.0-CURRENT FreeBSD 10.0-CURRENT #1 r248555: Wed Mar 20 15:00:20 UTC 2013 >Description: ===> ips (all) /usr/src/sys/modules/ips/../../dev/ips/ips.c:582:13: warning: variable 'dmamap' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (bus_dma_tag_create( /* parent */ sc->adapter_dmatag, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/src/sys/modules/ips/../../dev/ips/ips.c:626:44: note: uninitialized use occurs here bus_dmamem_free(dmatag, sc->copper_queue, dmamap); ^~~~~~ /usr/src/sys/modules/ips/../../dev/ips/ips.c:582:9: note: remove the 'if' if its condition is always false if (bus_dma_tag_create( /* parent */ sc->adapter_dmatag, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/src/sys/modules/ips/../../dev/ips/ips.c:581:21: note: initialize the variable 'dmamap' to silence this warning bus_dmamap_t dmamap; ^ = NULL 1 warning generated. >How-To-Repeat: cd /sys/modules/ips and do "make" to see clang warnings. >Fix: Index: sys/dev/ips/ips.c =================================================================== --- sys/dev/ips/ips.c (revision 248555) +++ sys/dev/ips/ips.c (working copy) @@ -578,7 +578,7 @@ { int error; bus_dma_tag_t dmatag; - bus_dmamap_t dmamap; + bus_dmamap_t dmamap = NULL; if (bus_dma_tag_create( /* parent */ sc->adapter_dmatag, /* alignemnt */ 1, /* boundary */ 0, >Release-Note: >Audit-Trail: >Unformatted: