From owner-p4-projects@FreeBSD.ORG  Sat Nov 22 09:40:18 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id ED94C16A4D0; Sat, 22 Nov 2003 09:40:17 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id BAC3616A4CE; Sat, 22 Nov 2003 09:40:17 -0800 (PST)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B797E43F85; Sat, 22 Nov 2003 09:40:16 -0800 (PST)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (localhost [127.0.0.1])
	by fledge.watson.org (8.12.9p2/8.12.9) with ESMTP id hAMHbxMg055688;
	Sat, 22 Nov 2003 12:37:59 -0500 (EST)
	(envelope-from robert@fledge.watson.org)
Received: from localhost (robert@localhost)hAMHbxn7055685;
	Sat, 22 Nov 2003 12:37:59 -0500 (EST)
	(envelope-from robert@fledge.watson.org)
Date: Sat, 22 Nov 2003 12:37:59 -0500 (EST)
From: Robert Watson <rwatson@FreeBSD.org>
X-Sender: robert@fledge.watson.org
To: "Brian F. Feldman" <green@FreeBSD.org>
In-Reply-To: <200311220338.hAM3cPvP025379@green.bikeshed.org>
Message-ID: <Pine.NEB.3.96L.1031122123614.47771A-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 42907 for review 
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2003 17:40:18 -0000


On Fri, 21 Nov 2003, Brian F. Feldman wrote:

> > @@ -204,7 +202,16 @@
> >  
> >      sudo make install
> >  
> > -  XXX: rename WindowServer, etc.
> > +  In order to run the WindowServer in our modified environment, you must
> > +  replace the existing WindowServer binary with our wrapper.  NOTE:
> > +  It is extremely important that these commands be executed cautiously:
> > +  the new name for the old WindowServer must be RealWindowServer, and
> > +  you really don't want to fail to rename before you install the new
> > +  one, or you end up with no WindowServer at all:
> > +
> > +    sudo mv /System/Library/CoreServices/WindowServer \
> > +      /System/Library/CoreServices/RealWindowServer
> > +    sudo make install-window-server-wrapper
> 
> cspath="/System/Library/CoreServices"
> if sudo mv "${cspath}/WindowServer" "${cspath/}RealWindowServer"; then
>   if ! sudo make install-window-server-wrapper || \
>    test ! -e "${cspath}/WindowServer"; then
>     sudo mv "${cspath}/RealWindowServer" "${cspath}/WindowServer"
>   fi
> fi
> 
> or something...

Two complicating factors:

(1) Darwin uses gmake, not BSD make
(2) We also want a test in there to make sure that WindowServer is rotated
    out once -- i.e., if you already have a RealWindowServer, we don't
    rotate.  Probably I should just add a make rule rule with a
    RealWindowServer target that is satisfied if the rename has already
    taken place.

Should definitely automate this step -- the risks of failure are pretty
nasty (Oh, I'm sorry, did we break your windowing system on an OS where
you need the windowing system to log in by default?).

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Network Associates Laboratories