From owner-freebsd-acpi@FreeBSD.ORG Sat Sep 30 19:26:37 2006 Return-Path: X-Original-To: freebsd-acpi@freebsd.org Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4EDBE16A597; Sat, 30 Sep 2006 19:26:37 +0000 (UTC) (envelope-from nate@root.org) Received: from ylpvm15.prodigy.net (ylpvm15-ext.prodigy.net [207.115.57.46]) by mx1.FreeBSD.org (Postfix) with ESMTP id D545443D66; Sat, 30 Sep 2006 19:26:34 +0000 (GMT) (envelope-from nate@root.org) X-ORBL: [71.139.46.150] Received: from [10.0.5.50] (ppp-71-139-46-150.dsl.snfc21.pacbell.net [71.139.46.150]) by ylpvm15.prodigy.net (8.13.8 out.dk.spool/8.13.8) with ESMTP id k8UJQYHA007995; Sat, 30 Sep 2006 15:26:34 -0400 Message-ID: <451EC4E6.7030304@root.org> Date: Sat, 30 Sep 2006 12:26:30 -0700 From: Nate Lawson User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: Matteo Riondato References: <20060930123244.GA29307@kaiser.sig11.org> In-Reply-To: <20060930123244.GA29307@kaiser.sig11.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-acpi@freebsd.org Subject: Re: Powerd patch review X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Sep 2006 19:26:37 -0000 Matteo Riondato wrote: > Hi folks, > I'm writing you to ask if you could be so kind to review the > attached patch to src/usr.sbin/powerd/powerd.c . It should fix the > problem descripted in PR bin/97198. I haven't a broken BIOS to test if > it really works, but it should. > Thanks > Best regards > P.s. I'm not subscribed to the list, so please CC me. > > > ------------------------------------------------------------------------ > > Index: powerd.c I thought this was already fixed and merged in July by Bruno. In any case, the right place to fix this is in the cpufreq driver (or acpi_perf, where I think this only occurs). See rev 1.21.2.3 of acpi_perf.c. Actually, it would be important to see if this is happening in another driver. The output of "sysctl dev.cpu" will show all the child drivers and settings so we can see if he's using acpi_perf or some other cpufreq driver. -- Nate