From owner-freebsd-ports@FreeBSD.ORG Sat Mar 27 12:02:12 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0567316A4CE for ; Sat, 27 Mar 2004 12:02:12 -0800 (PST) Received: from smtp1.netcologne.de (smtp1.netcologne.de [194.8.194.112]) by mx1.FreeBSD.org (Postfix) with ESMTP id C26D343D3F for ; Sat, 27 Mar 2004 12:02:11 -0800 (PST) (envelope-from thomas@laurel.tmseck.homedns.org) Received: from laurel.tmseck.homedns.org (xdsl-195-14-206-131.netcologne.de [195.14.206.131]) by smtp1.netcologne.de (Postfix) with SMTP id 3304A38CF9 for ; Sat, 27 Mar 2004 21:02:08 +0100 (MET) Received: (qmail 31712 invoked by uid 1001); 27 Mar 2004 20:01:36 -0000 Date: 27 Mar 2004 20:01:36 -0000 Message-ID: <20040327200136.31711.qmail@laurel.tmseck.homedns.org> From: tmseck-lists@netcologne.de (Thomas-Martin Seck) To: SADA Kenji Organization: private site In-Reply-To: <20040328023952.06ffa2ce.sada@FreeBSD.org> X-Newsgroups: gmane.os.freebsd.devel.ports X-Attribution: tms cc: freebsd-ports@freebsd.org Subject: Re: treating OPTIONS X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Mar 2004 20:02:12 -0000 * SADA Kenji [gmane.os.freebsd.devel.ports]: > .if exists(${LOCALBASE}/lib/libldap.so) > WITH_LDAP= yes > OPTIONS+= LDAP "Support for LDAP queries" on > .else > OPTIONS+= LDAP "Support for LDAP queries" off > .endif Please do not do this. IMHO, ports that autotune themselves are a bad idea and abusing OPTIONS for this is even worse. If you - as the maintainer - decide that LDAP support is optional, default the port to not include it. Period. If the user wants LDAP she can always say so herself, either via the commandline or via 'make config'.