Date: Mon, 21 Nov 2016 15:43:20 -0700 From: Adam Weinberger <adamw@adamw.org> To: Koop Mast <kwm@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r426722 - in head/lang: . pocl pocl/files Message-ID: <794F78AC-D823-48FE-91CC-83D6D123C4D9@adamw.org> In-Reply-To: <1479765873.1459.2.camel@FreeBSD.org> References: <201611211436.uALEaprl096393@repo.freebsd.org> <882131e7-54d5-9d24-98de-3297a29c187a@FreeBSD.org> <1479765873.1459.2.camel@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 21 Nov, 2016, at 15:04, Koop Mast <kwm@FreeBSD.org> wrote:
>=20
> On Mon, 2016-11-21 at 19:33 +0100, Mathieu Arnold wrote:
>> Le 21/11/2016 =C3=A0 15:36, Koop Mast a =C3=A9crit :
>>>=20
>>> +do-test:
>>> + cd ${WRKSRC} && ${GMAKE} check
>> NEVER use GMAKE, it is always called MAKE_CMD. Also, all this should
>> be
>> written as:
>>=20
>> TEST_TARGET=3D check
>=20
> I thik I looked up MAKE_CMD once but I don't use this that often so I
> probably forgot about that. I will try to keep it in mind for the next
> time. I didn't know about TEST_TARGET existence.
>=20
> These problems have been corrected, thanks for your comments!
(Mat is right here, TEST_TARGET is the way to go here).
Just FTR, personally I=E2=80=99m really into ${DO_MAKE_BUILD}, which =
sets up all the right environment and arguments and uses the proper =
MAKE_CMD.
${DO_MAKE_BUILD} check
DO_MAKE_BUILD is one of the most underrated macros in the ports system!
# Adam
=E2=80=94
Adam Weinberger
adamw@adamw.org
http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?794F78AC-D823-48FE-91CC-83D6D123C4D9>