From owner-freebsd-current@FreeBSD.ORG Mon Dec 18 19:06:35 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DFFBC16A407 for ; Mon, 18 Dec 2006 19:06:35 +0000 (UTC) (envelope-from cokane@mail.cokane.org) Received: from ms-smtp-02.texas.rr.com (ms-smtp-02.texas.rr.com [24.93.47.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id BADC743C9F for ; Mon, 18 Dec 2006 19:06:34 +0000 (GMT) (envelope-from cokane@mail.cokane.org) Received: from ramen.cokane.org (rrcs-24-153-184-158.sw.biz.rr.com [24.153.184.158]) by ms-smtp-02.texas.rr.com (8.13.6/8.13.6) with SMTP id kBIIJWDk023217 for ; Mon, 18 Dec 2006 12:19:32 -0600 (CST) Received: (qmail 7895 invoked by uid 1001); 18 Dec 2006 18:19:25 -0000 Date: Mon, 18 Dec 2006 18:19:25 +0000 From: Coleman Kane To: Brooks Davis Message-ID: <20061218181925.GA7885@ramen.coleyandcheryl> References: <20061218153906.GA6910@ramen.coleyandcheryl> <20061218163613.GA86127@lor.one-eyed-alien.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061218163613.GA86127@lor.one-eyed-alien.net> User-Agent: Mutt/1.4.1i X-Virus-Scanned: Symantec AntiVirus Scan Engine X-Mailman-Approved-At: Mon, 18 Dec 2006 23:03:28 +0000 Cc: freebsd-current@freebsd.org, Coleman Kane Subject: Re: UFS_GJOURNAL and ufs.ko X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2006 19:06:36 -0000 On Mon, Dec 18, 2006 at 10:36:13AM -0600, Brooks Davis wrote, and it was proclaimed: > On Mon, Dec 18, 2006 at 03:39:06PM +0000, Coleman Kane wrote: > > Hello, > > > > I have noticed (since adding UFS journal support) that the > > UFS_GJOURNAL option hasn't been added to the ufs.ko kernel > > module. I've been using this (out of an effort to test as > > much as possible as KLDs) and every time I upgrade my kernel > > I must manually add -DUFS_GJOURNAL to the CFLAGS line in > > its Makefile. > > > > Is there any specific reason why this can't be committed? > > So far, my experience with GJOURNAL has been great testing > > it both with journal+fs on the same device as well as on > > two seperate devices. > > > > It looks like an oversight to me, but I don't want to jump > > the gun on it if there is some reasonable argument to keep > > it out "by default". > > UFS_GJOURNAL is not enabled in GENERIC yet so it should not be enabled > in the module. At this time more review is needed before it can be > enabled by default (believe Kirk has been convinced to perform some > review). While Pawel's work looks good we need to be very, very careful > with UFS. We can't afford to have anything go wrong with our main > (essentially only) file system. > > -- Brooks I understand, thanks for the explanation. I'll just maintain it with my patchset for now. -- Coleman