From owner-svn-src-head@freebsd.org Fri Jan 25 18:13:21 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7235514BD1BF; Fri, 25 Jan 2019 18:13:21 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 13C468F443; Fri, 25 Jan 2019 18:13:21 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id D18DD17172; Fri, 25 Jan 2019 18:13:20 +0000 (UTC) Date: Fri, 25 Jan 2019 18:13:20 +0000 From: Alexey Dokuchaev To: rgrimes@freebsd.org, src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343416 - head/bin/sh Message-ID: <20190125181320.GA5015@FreeBSD.org> References: <201901251339.x0PDd5sG088601@pdx.rh.CN85.dnsmgr.net> <20190125060258.GA25351@v2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190125060258.GA25351@v2> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 13C468F443 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.87 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.87)[-0.873,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 18:13:21 -0000 On Fri, Jan 25, 2019 at 06:02:58AM +0000, Edward Napierala wrote: > The aliases are gone, let's continue on the remaining bits below. They are not gone, they were commented out; also, bogus double linefeeds are not gone. But most importantly, this whole file is useless and IMHO should just be removed. /bin/sh is not supposed to be one's interactive shell. > It is alien, because it's different from their experience > from other systems they are used to. This argument does not really hold because /bin/sh is not... see above. > It doesn't affect existing installs. It doesn't affect people > who run the default root shell (tcsh), nor folks who use shells AFAICT default root shell is /bin/csh, not tcsh. ;-) But that also means that /usr/src/bin/sh/dot.shrc doesn't have to exist: those who change the root shell should either pick another interactive shell, or if they want /bin/sh be ready to deal with sanitary environment. > And for folks who do have their own tree with their preferred > /root/.shrc to "make distribution" from, it should actually make > their diff to upstream smaller. I don't like extra files, esp. configuration files that look like they are for interactive shell while our /bin/sh is in fact not. This is confusing, and FreeBSD is not supposed to be confusing. > It is a syntax problem: > > trasz@v2:~ % while :; do date; sleep 1; done > while: Expression Syntax. > do: Command not found. > done: Command not found. Are you trying to use sh(1) loop in (t)csh? Why? And what does it have to do with the /usr/src/bin/sh/dot.shrc issue? ./danfe