From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Nov 12 13:00:00 2012 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C05B0AF9 for ; Mon, 12 Nov 2012 13:00:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 972C58FC16 for ; Mon, 12 Nov 2012 13:00:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qACD000m008748 for ; Mon, 12 Nov 2012 13:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qACD00jr008747; Mon, 12 Nov 2012 13:00:00 GMT (envelope-from gnats) Resent-Date: Mon, 12 Nov 2012 13:00:00 GMT Resent-Message-Id: <201211121300.qACD00jr008747@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, WATANABE Kazuhiro Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EFACBA6E for ; Mon, 12 Nov 2012 12:51:23 +0000 (UTC) (envelope-from CQG00620@nifty.ne.jp) Received: from mail1.asahi-net.or.jp (mail1.asahi-net.or.jp [202.224.39.197]) by mx1.freebsd.org (Postfix) with ESMTP id BD1808FC13 for ; Mon, 12 Nov 2012 12:51:23 +0000 (UTC) Received: from asahi-net.jp (h221030.dynamic.ppp.asahi-net.or.jp [61.114.221.30]) by mail1.asahi-net.or.jp (Postfix) with ESMTP id 44D1C107CBD for ; Mon, 12 Nov 2012 21:32:44 +0900 (JST) Message-Id: <20121112123244.44D1C107CBD@mail1.asahi-net.or.jp> Date: Mon, 12 Nov 2012 21:32:44 +0900 From: WATANABE Kazuhiro To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/173576: [patch] x11/rxvt: Wrong operators in Makefile X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: WATANABE Kazuhiro List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2012 13:00:00 -0000 >Number: 173576 >Category: ports >Synopsis: [patch] x11/rxvt: Wrong operators in Makefile >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Nov 12 13:00:00 UTC 2012 >Closed-Date: >Last-Modified: >Originator: WATANABE Kazuhiro >Release: FreeBSD 9.0-RELEASE-p4 i386 >Organization: >Environment: System: FreeBSD capricorn.sign.local 9.0-RELEASE-p4 FreeBSD 9.0-RELEASE-p4 #4 r239127M: Tue Aug 7 21:51:11 JST 2012 nabe@capricorn:/FreeBSD/obj/i386/releng_9.0/FreeBSD/releng_9.0/src/sys/GENERIC i386 >Description: The latest commit uses wrong operators in Makefile. It loses the previous definition of CONFIGURE_ARGS. See the patch below. "--disable-utmp" should be combined with "--disable-wtmp". If not, it occurs a compilation error. >How-To-Repeat: (With the operator's fix and without "--disable-wtmp") # cd /usr/ports/x11/rxvt # make BATCH=yes (snip) cc -DHAVE_CONFIG_H -c -DHAVE_LIBXPM -I/usr/local/include -I/usr/local/include/X11 -I. -I.. -I. -O2 -pipe -fno-strict-aliasing logging.c logging.c:66: warning: 'struct utmp' declared inside parameter list logging.c:66: warning: its scope is only this definition or declaration, which is probably not what you want logging.c: In function 'rxvt_update_wtmp': logging.c:85: error: invalid application of 'sizeof' to incomplete type 'struct utmp' *** Error code 1 Stop in /FreeBSD/ports/x11/rxvt/work/rxvt-2.6.4/src. *** Error code 1 Stop in /FreeBSD/ports/x11/rxvt/work/rxvt-2.6.4. *** Error code 1 Stop in /FreeBSD/ports/x11/rxvt. # >Fix: diff -urN rxvt.orig/Makefile rxvt/Makefile --- rxvt.orig/Makefile 2012-10-28 14:56:40.000000000 +0900 +++ rxvt/Makefile 2012-11-10 23:18:11.000000000 +0900 @@ -33,7 +33,7 @@ XIM_DESC= Build with XIM support XTERM_DESC= Build with Xterm scrollbar -CONFIGURE_ARGS= --enable-wtmp --enable-ttygid \ +CONFIGURE_ARGS= --enable-ttygid \ --with-xpm --enable-xpm-background \ --with-xpm-includes=${LOCALBASE}/include/X11 \ --with-xpm-library=${LOCALBASE}/lib @@ -44,9 +44,9 @@ # fails to build with new utmpx .if ${OSVERSION} > 900007 -CONFIGURE_ARGS= --disable-utmp +CONFIGURE_ARGS+= --disable-utmp --disable-wtmp .else -CONFIGURE_ARGS= --enable-utmp +CONFIGURE_ARGS+= --enable-utmp --enable-wtmp .endif .if ${PORT_OPTIONS:MBIG5} >Release-Note: >Audit-Trail: >Unformatted: