From owner-freebsd-hackers@FreeBSD.ORG Thu Oct 21 17:35:03 2004 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1660A16A4CE for ; Thu, 21 Oct 2004 17:35:03 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id EADFB43D4C for ; Thu, 21 Oct 2004 17:35:02 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id i9LHYuEd021672; Thu, 21 Oct 2004 10:34:56 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id i9LHYusw021671; Thu, 21 Oct 2004 10:34:56 -0700 Date: Thu, 21 Oct 2004 10:34:56 -0700 From: Brooks Davis To: soralx@cydem.org Message-ID: <20041021173456.GA20517@odin.ac.hmc.edu> References: <200410132110.09915.soralx@cydem.org> <200410171122.28021.soralx@cydem.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UlVJffcvxoiEqYs2" Content-Disposition: inline In-Reply-To: <200410171122.28021.soralx@cydem.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu cc: freebsd-hackers@freebsd.org Subject: Re: [PATCH] Re: Linksys PCM200 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 17:35:03 -0000 --UlVJffcvxoiEqYs2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 20, 2004 at 10:59:50PM -0600, soralx@cydem.org wrote: >=20 > [got no answer on hardware@] >=20 > I've tested this on 5.3-BETA7 - works OK, no more watchdog timeouts. > So could someone review those patches and add them to the source tree? > It's probably a good idea to update dc(4) and supported hw list also. I'm looking at this, though I have no hardware to test with. This patch suffers from cut-n-paste dammage and can not be applied directly. Please be more careful with this sort of thing in the future. > @@ -1978,6 +1982,7 @@ > case DC_DEVICEID_3CSOHOB: > case DC_DEVICEID_MSMN120: > case DC_DEVICEID_MSMN130_FAKE: /* XXX avoid collision with PNIC*/ > + case DC_DEVICEID_PCM200_AB09: > sc->dc_type =3D DC_TYPE_AN985; > sc->dc_flags |=3D DC_64BIT_HASH; > sc->dc_flags |=3D DC_TX_USE_TX_INTR; Should there be an DC_DEVICEID_PCM200_AB08 here? It certaintly looks like it won't work otherwise. Thanks for you submission. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --UlVJffcvxoiEqYs2 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBd/M/XY6L6fI4GtQRAllRAJ4vaQbzYBV38XXBSyqMqi3GBk6+/QCgsE2+ q/A0lE42UhbYZ++s8R5oWEw= =cbjx -----END PGP SIGNATURE----- --UlVJffcvxoiEqYs2--