Date: Thu, 4 Jun 2009 08:02:25 -0400 From: John Baldwin <jhb@freebsd.org> To: freebsd-current@freebsd.org, rea-fbsd@codelabs.ru Cc: kmacy@freebsd.org, khb@freebsd.org, Marius Strobl <marius@alchemy.franken.de>, rwatson@freebsd.org, FreeBSD Tinderbox <tinderbox@freebsd.org>, sparc64@freebsd.org, current@freebsd.org Subject: Re: [head tinderbox] failure on sparc64/sun4v Message-ID: <200906040802.27057.jhb@freebsd.org> In-Reply-To: <k2BOEYfMcn9Q2wvaWZK0dLZVLhc@BpFm1zkZmHABxHH1eUOcQSRoWTc> References: <20090602222445.2F6017302F@freebsd-current.sentex.ca> <20090603194453.GA43137@alchemy.franken.de> <k2BOEYfMcn9Q2wvaWZK0dLZVLhc@BpFm1zkZmHABxHH1eUOcQSRoWTc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 03 June 2009 11:26:17 pm Eygene Ryabinkin wrote: > > > By the way, having looked at sys/sys/pcpu.h, I see that there are parts > > > of 'struct pcpu' that depend on the KTR_PERCPU being defined and they > > > are never compensated with padding in PCPU_MD_FIELDS for sun4v. Is > > > KTR_PERCPU constant for sun4v (inexisting or defined everytime) or I am > > > missing something? > > > > It's just not taken into account but AFAICT also dead code. > > Yes, seems like so. John, may be we can eliminate the only reference to > KTR_PERCPU from sys/sys/pcpu.h? Both 'struct pcpu' fields seem to be > unused (grep'ped -CURRENT sources). Yes. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906040802.27057.jhb>