From owner-cvs-all Thu Aug 30 9:36:53 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id 0263437B401; Thu, 30 Aug 2001 09:36:23 -0700 (PDT) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [fec0::1:12]) by Awfulhak.org (8.11.5/8.11.5) with ESMTP id f7UGaLA71173; Thu, 30 Aug 2001 17:36:21 +0100 (BST) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.6/8.11.6) with ESMTP id f7UGaKf07929; Thu, 30 Aug 2001 17:36:20 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200108301636.f7UGaKf07929@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Dima Dorfman Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@freebsd-services.com Subject: Re: cvs commit: src/usr.sbin/pw grupd.c In-Reply-To: Message from Dima Dorfman of "Wed, 29 Aug 2001 23:32:17 PDT." <200108300632.f7U6WHB31855@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 30 Aug 2001 17:36:20 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > dd 2001/08/29 23:32:17 PDT > > Modified files: > usr.sbin/pw grupd.c > Log: > Unbreak group operations by reverting previous delta which removed the > assignment of `l' in `gr_update' to the return value of snprintf. It > claimed to have fixed the case where snprintf returned -1--in fact, it > broke the entire routine. Not setting `l' here causes fileupdate() to > invariably fail with EINVAL because it does its own check to assert > that the parameter isn't -1. > > Revision Changes Path > 1.10 +2 -2 src/usr.sbin/pw/grupd.c Pointy hat to: brian That was a bad mistake. I (wrongly) thought that the return value wasn't being used. Thanks for fixing this. -- Brian http://www.freebsd-services.com/ Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message